| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003367 | Spring engine | General | public | 2012-12-09 07:47 | 2012-12-22 04:54 | ||||
| Reporter | smoth | ||||||||
| Assigned To | cleanrock | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 91.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003367: Wait for turn is not always obeyed. | ||||||||
| Description | Seems that units do not always wait for turns before firing, resulting in both exploitable behavior and bugging looking fire animations. http://www.youtube.com/watch?v=nrcgH1BIap4 this works on both attacking ground and attacking targets | ||||||||
| Steps To Reproduce | load ba, /give cormort, give an attack order, after the shot fires and the barrel is reseting give an attack order in a random direction. The unit will simply fire the shot not obeying the waitforturn call. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2012-12-09 12:48 Last edited: 2012-12-09 12:49 |
first place to look instead of thinking "bug": BA's cormort has a turret=true weapon with default firing arc (360 degrees...) because no maxAngleDif is specified |
|
abma (administrator) 2012-12-09 13:18 |
@bug fixer: vulcans & bertha's suffer from this issue, too... so maybe most units / all units are affected in BA. |
|
smoth (reporter) 2012-12-09 16:49 |
Not just in ba, it happens in gundam and my test game. I have noticed it for years but assumed it was a script bug of mine. I didn't realize it was an actual issue until I noticed it in my new project. then I tried it in BA. so I have seen it in 3 different projects, always when there is a slow turning turret. all of the weapons in question are turret = true. |
|
2012-12-10 16:09 |
maybe wepon has high tolerance |
|
smoth (reporter) 2012-12-10 16:29 Last edited: 2012-12-10 16:32 |
Nope, the Morty doesn't have that.. |
|
Kloot (developer) 2012-12-10 16:41 Last edited: 2012-12-10 16:41 |
QUOTE: "BA's cormort has a turret=true weapon with DEFAULT FIRING ARC (360 DEGREES...)" ... |
|
smoth (reporter) 2012-12-10 16:45 Last edited: 2012-12-10 16:46 |
I read it, what is the point you are trying to convey? BA didn't use fire arcs like gundam I know this. I am not sure what your point in that quote is. It should be able to turn to fire However, if it has not finished it's rotation, it should wait for the animation to complete. It is NOT waiting for the turn animation, that is the problem. It is not only the mort any unit with a slow aim animation can trigger this. |
|
Kloot (developer) 2012-12-10 17:35 Last edited: 2012-12-10 17:37 |
The engine *only* cares about what AimWeapon returns (which is called every 15 frames _always_) and whether the firing angle is within a weapon's constraints. |
|
smoth (reporter) 2012-12-10 17:52 |
Aim weapon should not return before the turn is completed. If that isn't the issue, then maybe a new attack order isn't triggering the aim code? |
|
Kloot (developer) 2012-12-10 18:41 |
AimWeapon always has to return *before* a turn is completed, otherwise the engine would constantly be blocked by it. The way it works is that scripts usually make AimWeapon spawn a thread to do the turn animation and allow the weapon to fire when that finishes, so bugs like this can easily happen (for turret=true weapons with unlimited arcs) if an animation thread completes just after another one gets queued up by a new AimWeapon call. |
|
smoth (reporter) 2012-12-22 04:35 |
tried build: 91.0.1-129-gdbfd725 still possible. is this the incorrect build to test this in? |
|
abma (administrator) 2012-12-22 04:54 |
no, 91.0.1-629-g0321ee8 is the current develop build. that are 500 (!!!) more commits/changes. where did you get this build? this was/is the oldest develop available build! 91.0.1-129-gdbfd725 also doesn't contain the commit that fixes the issue... |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-12-09 07:47 | smoth | New Issue | |
| 2012-12-09 12:48 | Kloot | Note Added: 0009495 | |
| 2012-12-09 12:49 | Kloot | Note Edited: 0009495 | View Revisions |
| 2012-12-09 13:18 | abma | Note Added: 0009496 | |
| 2012-12-09 16:49 | smoth | Note Added: 0009498 | |
| 2012-12-10 16:09 |
|
Note Added: 0009502 | |
| 2012-12-10 16:29 | smoth | Note Added: 0009503 | |
| 2012-12-10 16:32 | smoth | Note Edited: 0009503 | View Revisions |
| 2012-12-10 16:41 | Kloot | Note Added: 0009504 | |
| 2012-12-10 16:41 | Kloot | Note Edited: 0009504 | View Revisions |
| 2012-12-10 16:45 | smoth | Note Added: 0009505 | |
| 2012-12-10 16:46 | smoth | Note Edited: 0009505 | View Revisions |
| 2012-12-10 17:35 | cleanrock | Assigned To | => cleanrock |
| 2012-12-10 17:35 | cleanrock | Status | new => assigned |
| 2012-12-10 17:35 | Kloot | Note Added: 0009506 | |
| 2012-12-10 17:37 | Kloot | Note Edited: 0009506 | View Revisions |
| 2012-12-10 17:52 | smoth | Note Added: 0009507 | |
| 2012-12-10 18:41 | Kloot | Note Added: 0009508 | |
| 2012-12-13 20:27 | cleanrock | Changeset attached | => spring develop 226dba60 |
| 2012-12-13 20:27 | cleanrock | Status | assigned => resolved |
| 2012-12-13 20:27 | cleanrock | Resolution | open => fixed |
| 2012-12-22 04:35 | smoth | Note Added: 0009527 | |
| 2012-12-22 04:35 | smoth | Status | resolved => feedback |
| 2012-12-22 04:35 | smoth | Resolution | fixed => reopened |
| 2012-12-22 04:54 | abma | Note Added: 0009528 | |
| 2012-12-22 04:54 | abma | Status | feedback => resolved |
| 2012-12-22 04:54 | abma | Resolution | reopened => fixed |
| Issue History |