2021-05-17 06:10 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0003342Spring engineGeneralpublic2012-12-17 23:52
ReporterBeherith 
Assigned Toabma 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version91.0 
Target VersionFixed in Version 
Summary0003342: [91.0.1-463] Units finished in labs have order queues overwritten
DescriptionUnits that get orders while under construction have their order queues overwritten on construction completion by the labs rally orders iff the lab has a rally point set. If lab has no rally points/orders then they retain their orders.

Steps To ReproduceBA 7.72, DSD. Make a lab, build a unit, give the unit under construction a move order, give the lab a different move order. Unit will have its queue overwritten by lab on completion.

Additional InformationTested with /luaui disable and /luarules disable too (BA 7.72 has gadget to make sure unit doesnt get stuck in lab)
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • diff file icon mantis3342-fix.diff (834 bytes) 2012-12-05 22:18 -
    diff --git a/rts/Sim/Units/UnitTypes/Factory.cpp b/rts/Sim/Units/UnitTypes/Factory.cpp
    index 561f5b8..7dfb5da 100644
    --- a/rts/Sim/Units/UnitTypes/Factory.cpp
    +++ b/rts/Sim/Units/UnitTypes/Factory.cpp
    @@ -436,13 +436,19 @@ void CFactory::AssignBuildeeOrders(CUnit* unit) {
     		}
     
     		c.PushPos(tmpPos);
    -		unit->commandAI->GiveCommand(c);
     	}
     
    -	for (CCommandQueue::const_iterator ci = newUnitCmds.begin(); ci != newUnitCmds.end(); ++ci) {
    -		c = *ci;
    -		c.options |= SHIFT_KEY;
    +	if (unit->commandAI->commandQue.empty()) {
     		unit->commandAI->GiveCommand(c);
    +
    +		// copy factory orders
    +		for (CCommandQueue::const_iterator ci = newUnitCmds.begin(); ci != newUnitCmds.end(); ++ci) {
    +			c = *ci;
    +			c.options |= SHIFT_KEY;
    +			unit->commandAI->GiveCommand(c);
    +		}
    +	} else {
    +		unit->commandAI->commandQue.push_front(c);
     	}
     }
     
    
    diff file icon mantis3342-fix.diff (834 bytes) 2012-12-05 22:18 +

-Relationships
related to 0003370resolvedKloot errors when aircraft exits lab 
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2012-11-24 20:13 Beherith New Issue
2012-12-05 22:18 Kloot File Added: mantis3342-fix.diff
2012-12-06 15:51 abma Changeset attached => spring develop 9194f9b1
2012-12-06 15:51 abma Assigned To => abma
2012-12-06 15:51 abma Status new => resolved
2012-12-06 15:51 abma Resolution open => fixed
2012-12-17 23:52 abma Relationship added related to 0003370
+Issue History