| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003086 | Spring engine | Lua | public | 2012-05-12 00:57 | 2012-05-12 01:46 | ||||
| Reporter | sprung | ||||||||
| Assigned To | jK | ||||||||
| Priority | normal | Severity | trivial | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 89.0 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003086: Fix for code - LuaUnsyncedCtrl::MarkerAddLine | ||||||||
| Description | The LuaUnsyncedCtrl::MarkerAddLine code in /rts/Lua/LuaUnsyncedCtrl.cpp has a few problems, namely: 1) in line 2743: (args != 6), should be ((args != 6) && (args != 7)), since now it has one more optional argument 2) in line 2744: !lua_isstring(L, 1), should be !lua_isnumber(L, 1), just like arguments 2 to 6 3) line 2761 is currently the same as line 2759 with the exception of the 'player' argument being always 1, which causes the lines not only to always be local, but also belonging to player 1 if they weren't set to be local (this might even be an enemy!). The line inMapDrawerModel->AddLine(pos1, pos2, true); should be inMapDrawer->SendLine(pos1, pos2, true); | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
jK (developer) 2012-05-12 01:46 |
https://github.com/spring/spring/commit/0bd5a1e711eff311091dfb59197f7d61f0dc803b |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-05-12 00:57 | sprung | New Issue | |
| 2012-05-12 01:46 | jK | Note Added: 0008681 | |
| 2012-05-12 01:46 | jK | Status | new => resolved |
| 2012-05-12 01:46 | jK | Resolution | open => fixed |
| 2012-05-12 01:46 | jK | Assigned To | => jK |
| Issue History |