View Issue Details

IDProjectCategoryView StatusLast Update
0003041Spring engineGeneralpublic2013-01-14 04:48
Reporterabma Assigned ToKloot  
PriorityhighSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Product Version91.0.1+git 
Summary0003041: fix savegame support: Allow Spring.CreateUnit to take a unitID & allow to set gameframe
Descriptionthe engine save-game support is badly broken.

it should be either removed or fixed as we already have a lua-based save-game support.
Additional Informationhttp://springrts.com/phpbb/viewtopic.php?f=23&t=21805
http://springrts.com/phpbb/viewtopic.php?f=23&t=21836


see meeting minutes for a todo:

http://springrts.com/phpbb/viewtopic.php?f=73&t=28088
TagsNo tags attached.
Checked infolog.txt for Errors

Relationships

has duplicate 0001828 resolvedabma Spring crashes when I trying to load savegames 

Activities

abma

2012-11-25 02:54

administrator   ~0009377

Last edited: 2012-11-25 03:02

not sure if thats an issue, but it seems to be "easily" possible to serialze lua state:

http://lua-users.org/lists/lua-l/2002-09/msg00139.html

http://luaforge.net/projects/pluto/

abma

2012-11-28 01:47

administrator   ~0009408

some more info:
http://springrts.com/phpbb/viewtopic.php?f=21&t=28889

abma

2013-01-01 15:59

administrator   ~0009543

Last edited: 2013-01-01 16:00

to fix, two features has to be added (http://springrts.com/phpbb/viewtopic.php?f=21&t=28889):

1. Allow Spring.CreateUnit to take a unitID argument (and featureID arg for Spring.CreateFeature), allowing the gadget to recreate the units/features with their original IDs and eliminate the need for a mapping function. Throw an error if the ID is already taken or out of bounds.

2) The loaded game starts at t=0, rather than the time of the saved game (i.e. n gameframes in), add some way to set the frame / add some fastskip command?

not sure where gameframe is also used, i guess its used in some statistics calculation?

(set to feature request / high as its needed for campaign & single-player)

Issue History

Date Modified Username Field Change
2012-03-28 16:27 abma New Issue
2012-03-28 16:28 abma Relationship added related to 0001828
2012-03-28 16:28 abma Relationship replaced has duplicate 0001828
2012-05-10 08:54 abma Summary Cleanup savegames support => fix savegame support
2012-05-10 08:54 abma Additional Information Updated
2012-05-10 08:55 abma Severity feature => minor
2012-11-25 02:54 abma Note Added: 0009377
2012-11-25 03:02 abma Note Edited: 0009377
2012-11-28 01:47 abma Note Added: 0009408
2013-01-01 15:59 abma Note Added: 0009543
2013-01-01 15:59 abma Priority normal => high
2013-01-01 15:59 abma Severity minor => feature
2013-01-01 16:00 abma Note Edited: 0009543
2013-01-01 16:02 abma Summary fix savegame support => fix savegame support: Allow Spring.CreateUnit to take a unitID & allow to set gameframe
2013-01-01 16:02 abma Product Version 89.0 => 91.0.1+git
2013-01-14 04:48 Kloot Changeset attached => spring develop 89955d35
2013-01-14 04:48 Kloot Assigned To => Kloot
2013-01-14 04:48 Kloot Status new => resolved
2013-01-14 04:48 Kloot Resolution open => fixed