| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003041 | Spring engine | General | public | 2012-03-28 16:27 | 2013-01-14 04:48 | ||||
| Reporter | abma | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | high | Severity | feature | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 91.0.1+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003041: fix savegame support: Allow Spring.CreateUnit to take a unitID & allow to set gameframe | ||||||||
| Description | the engine save-game support is badly broken. it should be either removed or fixed as we already have a lua-based save-game support. | ||||||||
| Additional Information | http://springrts.com/phpbb/viewtopic.php?f=23&t=21805 http://springrts.com/phpbb/viewtopic.php?f=23&t=21836 see meeting minutes for a todo: http://springrts.com/phpbb/viewtopic.php?f=73&t=28088 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
abma (administrator) 2012-11-25 02:54 Last edited: 2012-11-25 03:02 |
not sure if thats an issue, but it seems to be "easily" possible to serialze lua state: http://lua-users.org/lists/lua-l/2002-09/msg00139.html http://luaforge.net/projects/pluto/ |
|
abma (administrator) 2012-11-28 01:47 |
some more info: http://springrts.com/phpbb/viewtopic.php?f=21&t=28889 |
|
abma (administrator) 2013-01-01 15:59 Last edited: 2013-01-01 16:00 |
to fix, two features has to be added (http://springrts.com/phpbb/viewtopic.php?f=21&t=28889): 1. Allow Spring.CreateUnit to take a unitID argument (and featureID arg for Spring.CreateFeature), allowing the gadget to recreate the units/features with their original IDs and eliminate the need for a mapping function. Throw an error if the ID is already taken or out of bounds. 2) The loaded game starts at t=0, rather than the time of the saved game (i.e. n gameframes in), add some way to set the frame / add some fastskip command? not sure where gameframe is also used, i guess its used in some statistics calculation? (set to feature request / high as its needed for campaign & single-player) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-03-28 16:27 | abma | New Issue | |
| 2012-03-28 16:28 | abma | Relationship added | related to 0001828 |
| 2012-03-28 16:28 | abma | Relationship replaced | has duplicate 0001828 |
| 2012-05-10 08:54 | abma | Summary | Cleanup savegames support => fix savegame support |
| 2012-05-10 08:54 | abma | Additional Information Updated | |
| 2012-05-10 08:55 | abma | Severity | feature => minor |
| 2012-11-25 02:54 | abma | Note Added: 0009377 | |
| 2012-11-25 03:02 | abma | Note Edited: 0009377 | View Revisions |
| 2012-11-28 01:47 | abma | Note Added: 0009408 | |
| 2013-01-01 15:59 | abma | Note Added: 0009543 | |
| 2013-01-01 15:59 | abma | Priority | normal => high |
| 2013-01-01 15:59 | abma | Severity | minor => feature |
| 2013-01-01 16:00 | abma | Note Edited: 0009543 | View Revisions |
| 2013-01-01 16:02 | abma | Summary | fix savegame support => fix savegame support: Allow Spring.CreateUnit to take a unitID & allow to set gameframe |
| 2013-01-01 16:02 | abma | Product Version | 89.0 => 91.0.1+git |
| 2013-01-14 04:48 | Kloot | Changeset attached | => spring develop 89955d35 |
| 2013-01-14 04:48 | Kloot | Assigned To | => Kloot |
| 2013-01-14 04:48 | Kloot | Status | new => resolved |
| 2013-01-14 04:48 | Kloot | Resolution | open => fixed |
| Issue History |