View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003040 | Spring engine | General | public | 2012-03-28 00:08 | 2013-02-19 16:46 |
| Reporter | Beherith | Assigned To | abma | ||
| Priority | normal | Severity | text | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0003040: //SPRINGSETTINGS DO NOT TOUCH in uikeys.txt | ||||
| Description | Since springsettings and springlobby is included by default in the install, could we please have the //SPRINGSETTINGS DO NOT TOUCH line documented in the uikeys.txt. It took me quite a bit of searching to actually find the exact line needed even though I knew about the existence of a feature to prevent springsettings from mucking with my config. Thanks! | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
what are the benefits of adding this line? with this line others will complain: "why doesn't springsettings store the changed settings?" imo that would be a bad default. edit: can this line somehow added, so it doesn't take effect, but describes, how this can be enabled? imo this would be the "nicer" solution. |
|
|
Yeah, I meant just documenting it, not actually adding it. |
|
|
https://github.com/springlobby/springlobby/blob/master/src/settings%2B%2B/hotkeys/hotkey_parser.cpp#L41 how to do that in a clean way? i would prefer to either make springsettings work, that it doesn't overwrite config or make it a setting in springsettings or let it ask, if it should overwrite / save. |
|
|
if ( line.Trim().StartsWith( wxT("//SPRINGSETTINGS DO NOT TOUCH") ) ) Add the following to uikeys.txt: // If you wish to aviod SpringSettings parsing and possibly ovewriting your uikeys.txt, please uncomment the following line: (note that the line has two sets of // comment indicators, remove only one set) ////SPRINGSETTINGS DO NOT TOUCH |
|
|
http://springrts.com/wiki/Uikeys.txt |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-03-28 00:08 | Beherith | New Issue | |
| 2012-03-28 12:02 | abma | Note Added: 0008532 | |
| 2012-03-28 12:02 | abma | Status | new => feedback |
| 2012-03-28 12:03 | abma | Note Edited: 0008532 | |
| 2012-03-28 22:46 | Beherith | Note Added: 0008539 | |
| 2012-03-28 23:10 | abma | Note Added: 0008540 | |
| 2012-04-02 14:37 | Beherith | Note Added: 0008553 | |
| 2012-04-02 18:01 | abma | Status | feedback => new |
| 2013-02-19 16:46 | abma | Note Added: 0009850 | |
| 2013-02-19 16:46 | abma | Status | new => closed |
| 2013-02-19 16:46 | abma | Assigned To | => abma |
| 2013-02-19 16:46 | abma | Resolution | open => fixed |
