| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002930 | Spring engine | Lua | public | 2012-01-25 20:10 | 2014-10-31 18:36 | ||||
| Reporter | FLOZi | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | trivial | Reproducibility | N/A | ||||
| Status | closed | Resolution | fixed | ||||||
| Product Version | 85.0.1 | ||||||||
| Target Version | Fixed in Version | 86.0 | |||||||
| Summary | 0002930: Default gadgetHandler limits the range of registerable custom CmdIDs | ||||||||
| Description | Default gadgets.lua will only register cmd IDs in the range 30000 <= cmdID < 40000 https://github.com/spring/spring/blob/master/cont/base/springcontent/LuaGadgets/gadgets.lua#L892 (This doesn't actually preclude their use if they are not registered) | ||||||||
| Additional Information | This is based on trepans old proposals: -- all negative: Engine (build commands) -- 0 - 999: Engine -- 1000 - 9999: Group AI -- 10000 - 19999: LuaUI -- 20000 - 29999: LuaCob -- 30000 - 39999: LuaRules Which are now outdated, as GroupAI and LuaCob no longer even exist, and I don't see a need to enforce separation of LuaUI and LuaRules? It seems to me that any (non-duplicated) value >= 1000 should be registrable. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2012-02-16 16:01 |
I don't know which projects still use the default handler, but checking ID restrictions on the Lua side makes little sense anyway. They're lifted now. |
|
FLOZi (reporter) 2013-04-03 02:55 |
Really minor issue... gadget-handler now disallows any id <= 1000, it should be < 1000 imo. Feel free to re-close and tell me to stop wasting your time. Also, plenty of projects use base content handler :) |
|
Cubex (reporter) 2013-04-04 16:26 |
Resurrection bot, See what did you did here. There are still projects that use a forked old gadgethandler with the old limit of 30000 <-> 40000.... *cof* 0K *cof* |
|
abma (administrator) 2014-10-31 18:36 |
> There are still projects that use a forked old gadgethandler with the old limit of 30000 <-> 40000.... *cof* 0K *cof* they need to use the "new" gadgethandler, no need to change at engine side (if i understood it correctly) |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-25 20:10 | FLOZi | New Issue | |
| 2012-02-16 16:01 | Kloot | Note Added: 0008292 | |
| 2012-02-16 16:01 | Kloot | Status | new => resolved |
| 2012-02-16 16:01 | Kloot | Fixed in Version | => 86.0 |
| 2012-02-16 16:01 | Kloot | Resolution | open => fixed |
| 2012-02-16 16:01 | Kloot | Assigned To | => Kloot |
| 2013-04-03 02:55 | FLOZi | Note Added: 0010373 | |
| 2013-04-03 02:55 | FLOZi | Status | resolved => feedback |
| 2013-04-03 02:55 | FLOZi | Resolution | fixed => reopened |
| 2013-04-04 16:26 | Cubex | Note Added: 0010387 | |
| 2014-10-31 18:36 | abma | Note Added: 0013789 | |
| 2014-10-31 18:36 | abma | Status | feedback => closed |
| 2014-10-31 18:36 | abma | Resolution | reopened => fixed |
| Issue History |