View Issue Details

IDProjectCategoryView StatusLast Update
0002833Spring engineUnit Scriptingpublic2011-12-14 16:25
ReporterGoogle_Frog Assigned ToKloot  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Fixed in Version85.0 
Summary0002833: Some factories cannot build
Descriptionfactoryjump, factoryplane, factoryveh and factorytank cannot build. It's either a bug or possibly an uncommunicated change.
Additional InformationZero-K test-4554
spring_84.0.1-461-gae47ae2
TagsNo tags attached.
Attached Files
20111214_202146_Comet Catcher Redux_84.0.1-461-gae47ae2 develop factory.sdf (Attachment missing)
Checked infolog.txt for Errors

Activities

Kloot

2011-12-14 12:24

developer   ~0007911

Do the scripts of those factories set INBUILDSTANCE to true at any point?

Google_Frog

2011-12-14 13:06

reporter   ~0007912

Last edited: 2011-12-14 13:11

Yes, if by true you mean SetUnitValue(COB.INBUILDSTANCE, 1).

For all of them it is toggled in Activate and Deactivate.

factoryveh is cob and the others are lua so there is no common cause there.

Kloot

2011-12-14 13:29

developer   ~0007915

Last edited: 2011-12-14 13:31

The problem is that for these factories the change to inBuildStance is not visible from the engine's perspective, so I'm rather more interested in the difference between eg. factoryveh and one that does build than between factoryveh and factoryplane et all.

Kloot

2011-12-14 14:53

developer   ~0007919

Last edited: 2011-12-14 14:55

The following steps are necessary to make factoryplane build in zk 0.9.2 and spring-e8639f4065570138ccb1b44087219caa5ca62f17:

    remove the SetSignalMask(1) on line 41 of scripts/factoryplane.lua OR the Signal(1) on line 83
    /cheat /give factoryplane
    /luarules reload (due to some unrelated gadget error)

It seems a recent refactor of mine is responsible, but the net effect is that every call from the engine to Activate --> StartThread(Open) --> StopThread(Close) --> StopThread(Open) prevents the inBuildStance change, and so long as inBuildStance is false this cycle continues. Thus the factory locks up.

Issue History

Date Modified Username Field Change
2011-12-14 10:36 Google_Frog New Issue
2011-12-14 10:36 Google_Frog File Added: 20111214_202146_Comet Catcher Redux_84.0.1-461-gae47ae2 develop factory.sdf
2011-12-14 12:24 Kloot Note Added: 0007911
2011-12-14 12:24 Kloot Status new => feedback
2011-12-14 13:06 Google_Frog Note Added: 0007912
2011-12-14 13:11 Google_Frog Note Edited: 0007912
2011-12-14 13:29 Kloot Note Added: 0007915
2011-12-14 13:29 Kloot Note Edited: 0007915
2011-12-14 13:31 Kloot Note Edited: 0007915
2011-12-14 14:53 Kloot Note Added: 0007919
2011-12-14 14:55 Kloot Note Edited: 0007919
2011-12-14 15:38 Kloot Status feedback => assigned
2011-12-14 15:38 Kloot Assigned To => Kloot
2011-12-14 16:25 Kloot Status assigned => resolved
2011-12-14 16:25 Kloot Fixed in Version => 85.0
2011-12-14 16:25 Kloot Resolution open => fixed