View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002705 | Spring engine | General | public | 2011-11-06 16:57 | 2011-11-07 16:18 |
| Reporter | abma | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 83.0 | ||||
| Fixed in Version | 84.0 | ||||
| Summary | 0002705: Many: "Got invalid Select: Invalid unit ID" messages | ||||
| Description | seems to happen many times in every game... message is from: rts/Game/NetCommands.cpp:425 | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
there are several reasons why these might show up more often than before: 1) Spring netcode became laggier and/or buggier 2) people's connections became laggier 3) Spring filters fewer of them for printing 4) ID's of destroyed units are not recycled as quickly, so delayed selection packets contain more references to NULL units on average (most probable) with the exception of 1 (which would need testing to prove) there is no cause for alarm though. edit: seems like there is more going on, do you have any demos? |
|
|
sure, see attached file... (created with: /cheat /give 100 armflea, selected armflea, ctrl+d + gave many commands to them...) |
|
|
Thanks, now I know what the problem is: [f=0001216] Warning: Bandwidth limit was reached for [AG]abma [packets delayed] (the new bandwidth limiting of course means extra artificial lag gets introduced even over local connections) |
|
|
i can produce "Got invalid Select: Invalid unit ID" without "bandwidth limit reached", gimme a sec :) (edit: see attached filed) just crl+d the unit + give some commands close to the point where it self-destroys -> the error message. |
|
|
looks like the various GlobalConfig::Link* defaults may be set too low then. :) |
|
|
IMO not related to network lag. Spring did simply not print these warnings in 0.82. The entire command was completely rejected: https://github.com/spring/spring/commit/8313da06049b0e7b1ae2574a84cd8bd700de34b8 but then I changed it into a warning: https://github.com/spring/spring/commit/b92fe2382c7cae3caf380f924d25ad09c04cf754 |
|
|
The command was only rejected in 0.82 when an ID fell outside the range [0, maxUnits - 1]. ID's pointing to valid-but-NULL unit slots were skipped without warning (as now). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-06 16:57 | abma | New Issue | |
| 2011-11-06 16:58 | abma | Product Version | => 83.0 |
| 2011-11-06 19:47 | Kloot | Note Added: 0007514 | |
| 2011-11-06 19:47 | Kloot | Note Edited: 0007514 | |
| 2011-11-06 21:07 | Kloot | Note Edited: 0007514 | |
| 2011-11-06 21:11 | Kloot | Status | new => feedback |
| 2011-11-06 21:39 | abma | File Added: 20111106_213803_CloseCombat_83.0.1-4-g0221f13 develop.sdf | |
| 2011-11-06 21:40 | abma | Note Added: 0007518 | |
| 2011-11-06 21:40 | abma | Status | feedback => new |
| 2011-11-06 21:55 | Kloot | Note Added: 0007519 | |
| 2011-11-06 21:57 | abma | Note Added: 0007520 | |
| 2011-11-06 21:58 | abma | File Added: 20111106_215803_CloseCombat_83.0.1-4-g0221f13 develop.sdf | |
| 2011-11-06 21:59 | abma | Note Edited: 0007520 | |
| 2011-11-06 22:01 | abma | Note Edited: 0007520 | |
| 2011-11-06 22:14 | Kloot | Note Added: 0007521 | |
| 2011-11-07 02:32 | zerver | Note Added: 0007523 | |
| 2011-11-07 16:18 | Kloot | Note Added: 0007531 | |
| 2011-11-07 16:18 | Kloot | Status | new => closed |
| 2011-11-07 16:18 | Kloot | Resolution | open => no change required |
| 2011-11-07 16:18 | Kloot | Fixed in Version | => 84.0 |
