| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002466 | Spring engine | General | public | 2011-06-11 22:06 | 2011-06-12 12:35 | ||||
| Reporter | FLOZi | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | feature | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.82.7+git | ||||||||
| Target Version | Fixed in Version | 0.82.7+git | |||||||
| Summary | 0002466: UnitDef Attribute 'losHeight' is not set-able | ||||||||
| Description | First of all this works under the assumption that losHeight is used (as its name suggests) in determining from where on the unit its LOS is calculated from. If that is a false assumption I apologise and this issue can be closed. https://github.com/spring/spring/blob/master/rts/Sim/Units/UnitDef.cpp#L302 This attribute is not settable in the lua definition file, and it seems even that the value in UnitDef.ccp is ignored: https://github.com/spring/spring/blob/master/rts/Sim/Units/Unit.cpp#L477 And instead a value based on the unit radius is used. | ||||||||
| Additional Information | I was under the impression that radar etc was determined by the unit models 'height', not it's radius. If that is the case it would be nice to be consistent with LOS, if feasible. Furthermore of course it would be nice to be able to set it independently in the unitdef file, unless this would "cause terrible things to happen". | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2011-06-12 12:35 |
fixed (new tags are "losEmitHeight" and "radarEmitHeight") |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-06-11 22:06 | FLOZi | New Issue | |
| 2011-06-11 22:06 | FLOZi | Graphics Card | => unknown |
| 2011-06-12 12:35 | Kloot | Note Added: 0006733 | |
| 2011-06-12 12:35 | Kloot | Status | new => resolved |
| 2011-06-12 12:35 | Kloot | Fixed in Version | => 0.82.7+git |
| 2011-06-12 12:35 | Kloot | Resolution | open => fixed |
| 2011-06-12 12:35 | Kloot | Assigned To | => Kloot |
| Issue History |