2018-12-12 06:26 CET

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002370Spring engineGeneralpublic2018-11-11 15:40
Reporterabma 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
Product Version 
Target Version83.0Fixed in Version 
Summary0002370: disallow depends on filenames in modinfo.lua
Descriptionif a file is renamed, it can't be found as a depend. this is also true, if a file is published in rapid, so please disable this "feature".

This makes more problems, for example on springfiles/plasma... finding a depending file is impossible, if the original filename is lost. (could happen on upload)
TagsNo tags attached.
Attached Files

-Relationships
related to 0003000resolvedabma unitsync doesn't list missing files as depend 
related to 0002315resolved (unitsync) modinfo.lua lacks "Author" attribute 
+Relationships

-Notes

~0019514

gajop (developer)

I can do this if it is still wanted and if wanted behavior can be specified. I can see how having archive names (e.g. $name.sdz / $name.sdd) can pause a parsing a problem for the infra.

I think we should only allow rapid and full name dependencies (e.g. "rapid://ba:stable" or "Balanced Annihilation V10.14"). What would you like to happen with builtin archives like bitmap.sdz?
There's a few cases of "cursor.sdz", "springcontent.sdz" and similar being specified in the depend tables of some games. Is this a user error or should parsing ignore builtin archives?

~0019515

abma (administrator)

> What would you like to happen with builtin archives like bitmap.sdz?

IMHO it should be handled the same as for "normal" archives. all base content contains a modinfo.lua, so no real special handling is required. its only a different type of archive.

> There's a few cases of "cursor.sdz", "springcontent.sdz" and similar being specified in the depend tables of some games. Is this a user error or should parsing ignore builtin archives?

IMHO thats an user error. not sure how many maps are doing this wrong.
+Notes

-Issue History
Date Modified Username Field Change
2011-02-27 08:21 abma New Issue
2011-02-27 08:22 abma Summary disallow depends on filenames => disallow depends on filenames in modinfo.lua
2011-06-10 18:12 hoijui Target Version => 0.83.0
2012-03-06 00:51 abma Relationship added related to 0003000
2012-03-08 23:11 abma Relationship added related to 0002315
2018-11-11 15:29 gajop Note Added: 0019514
2018-11-11 15:40 abma Note Added: 0019515
+Issue History