View Issue Details

IDProjectCategoryView StatusLast Update
0002210Spring engineLuapublic2010-11-07 11:38
Reporterquantum Assigned Tohoijui  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.82.6.1 
Summary0002210: Suspicious code in gadget handler
Description"gadgetHandler:AllowResourceLevel(teamID, res, level)" and "gadgetHandler:AllowResourceTransfer(teamID, res, level)" have the same parameters. This does not seem correct for AllowResourceTransfer.

The following parameters appear in Zero-K's share levels gadget:
"AllowResourceTransfer(oldTeam, newTeam, type, amount)"
TagsNo tags attached.
Checked infolog.txt for Errors

Activities

hoijui

2010-11-07 11:38

reporter   ~0005840

thank you! :-)
fixed in commit:
https://github.com/spring/spring/commit/a5239cec66a2d1dc345450f2074cbbd4a2e352ca

even the share_control.lua in springs own base content already used the correct parameters, just not the gadget handler.

Issue History

Date Modified Username Field Change
2010-11-07 02:41 quantum New Issue
2010-11-07 11:30 hoijui Status new => assigned
2010-11-07 11:30 hoijui Assigned To => hoijui
2010-11-07 11:38 hoijui Note Added: 0005840
2010-11-07 11:38 hoijui Status assigned => resolved
2010-11-07 11:38 hoijui Resolution open => fixed