2025-07-20 05:34 CEST
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002196Spring engineUnit Scriptingpublic2010-11-02 10:182011-12-02 17:18
Reporteruser744 
Assigned ToKloot 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
Product Version0.82.6.1 
Target VersionFixed in Version84.0.1 
Summary0002196: faulty Lua CEG effects crash spring.exe
Descriptiontrying to call it via Spring.SpawnCEG crashes spring.exe
Additional Informationinfolog:
http://pastebin.ca/1979438

--used by miners when they return full of resources
return {
  ["resdropoff"] = {
    resdropoff = {
      air = true,
      class = [[CSimpleParticleSystem]],
      count = 1,
      ground = true,
      underwater = 1,
      useairlos = true,
      water = true,
      alwaysVisible = 1,
      properties = {
        alwaysVisible = 1,
        airdrag = 0.9,
        colormap = [[0.0 0.8 0.0 0.8 0.2 0.8 0.02 0.6 0.4 0.8 0.4 0.4 0.8 0.8 0.8 0.1]],
        directional = false,
        emitrot = 90,
        emitrotspread = 10,
        emitvector = [[0, 1, 0]],
        gravity = [[0, 0, 0]],
        numparticles = 1,
        particlelife = 50,
        particlelifespread = 50,
        particlesize = 5,
        particlesizespread = 10,
        particlespeed = 1.5, --[[0.0025 r, 1 r1.0, 0.0025 r]],
        particlespeedspread = 1.5,
        pos = [[0, 0, 0]],
        sizegrowth = 0.8,
        sizemod = 1.0,
        texture = [[tpsmoke]],
      },
    },
  },

}


yes i know this line:
particlespeed = 1.5, --[[0.0025 r, 1 r1.0, 0.0025 r]],
is not correct (actually quite the annoying mistake without synthax hightligting) and spring says so in infolog.
Still mod content should not be able to crash the engine i think?
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
related to 0002228resolvedabma Spring.exe should give more & better error messages 
related to 0001321resolvedKloot Crashes and poor feedback on missing content 
+Relationships

-Notes

~0005815

user744

2010-11-02 10:24

 actually it even crashes if you do
particlespeed = [[0.0025 r, 1 r1.0, 0.0025 r]],
instead of
particlespeed = 1.5,
(seems like a number instead of vector is wanted here)

and in this case infolog.txt gives NO error message!

~0005911

abma (administrator)

2010-11-22 10:55

 translated:

F:\Spiele\Spring_81\spring.exe 0x1096adf cygming-crtend.c:0
F:\Spiele\Spring_81\spring.exe 0xcbb5c2 GameData.cpp:0
F:\Spiele\Spring_81\spring.exe 0x84d8b0 /usr/lib/gcc/i586-mingw32msvc/4.4.2/include/c++/bits/stl_tree.h:1182
F:\Spiele\Spring_81\spring.exe 0x5e2a86 rts/Lua/LuaSyncedCtrl.cpp:3326
F:\Spiele\Spring_81\spring.exe 0xa77118 rts/lib/lua/src/ldo.cpp:319
F:\Spiele\Spring_81\spring.exe 0xa73111 rts/lib/lua/src/lvm.cpp:609
F:\Spiele\Spring_81\spring.exe 0xa77480 rts/lib/lua/src/ldo.cpp:377
F:\Spiele\Spring_81\spring.exe 0xa658a1 rts/lib/lua/src/lapi.cpp:822
F:\Spiele\Spring_81\spring.exe 0xa76c7b rts/lib/lua/src/ldo.cpp:119
F:\Spiele\Spring_81\spring.exe 0xa76cd9 rts/lib/lua/src/ldo.cpp:464
F:\Spiele\Spring_81\spring.exe 0xa656ea rts/lib/lua/src/lapi.cpp:843
F:\Spiele\Spring_81\spring.exe 0x664434 rts/Lua/LuaHandle.cpp:226
F:\Spiele\Spring_81\spring.exe 0x6645c4 rts/Lua/LuaHandle.cpp:255
F:\Spiele\Spring_81\spring.exe 0x5b60ea rts/Lua/LuaHandleSynced.cpp:719
F:\Spiele\Spring_81\spring.exe 0x404184 rts/Game/Game.cpp:3582
F:\Spiele\Spring_81\spring.exe 0x4237d6 rts/System/Sync/SyncChecker.h:40
F:\Spiele\Spring_81\spring.exe 0x42b400 rts/Game/Game.cpp:2832
F:\Spiele\Spring_81\spring.exe 0x9869f1 rts/System/SpringApp.cpp:1051
F:\Spiele\Spring_81\spring.exe 0x991d39 rts/System/SpringApp.cpp:1182
F:\Spiele\Spring_81\spring.exe 0x992064 rts/System/Main.cpp:55
F:\Spiele\Spring_81\spring.exe 0x992840 rts/System/Main.cpp:91
F:\Spiele\Spring_81\spring.exe 0x4010a7 buildd/mingw32-runtime-3.15.2/build_dir/src/mingwrt-3.15.2-mingw32/crt1.c:237
F:\Spiele\Spring_81\spring.exe 0x401123 buildd/mingw32-runtime-3.15.2/build_dir/src/mingwrt-3.15.2-mingw32/crt1.c:271
E:\WINDOWS\system32\kernel32.dll 0x7C816FF7 ??:0

~0006118

Kloot (developer)

2010-12-21 17:16

 Changed some of the more common CTD-producing errors to now spam warnings.

~0007792

user744

2011-12-02 15:29

 CSimpleParticleSystem with no texture crash.
Invalid textures are ok, if the tag is missing completly->crash as soon effect is spawned.

infolog:
http://pastebin.com/swBzsGa3
crashy ceg:
http://pastebin.com/eveDdbmv

~0007793

Kloot (developer)

2011-12-02 16:05

 I see you added the CEG to XTA 9.674, got a test mutator?

~0007794

user744

2011-12-02 16:09

Last edited: 2011-12-02 16:14

 actually added it to a map:
knorke.darkstars.co.uk/RoadMap6.sdd.zip

dont mind the random stuff everywhere, wip.
scripts\tpsmothship.lua -> uses EmitSfx with the CEG
units\tpsmothship.lua -> unit with above script
gadgets\tp_ship.lua -> spawns above unit
gamedata\explosions\tpexhaust.lua.works -> CEG version that does not crash

semi-related:
The non-crashing version actually gets no correct texture either but not sure if bug or doing it wrong:
http://springrts.com/phpbb/viewtopic.php?f=13&t=27236

~0007795

user744

2011-12-02 16:27

 oh:
/give tpsmothship

~0007796

Kloot (developer)

2011-12-02 17:18

 Thanks, fixed.

"not sure if bug or doing it wrong"

Doing it slightly wrong, see topic.
+Notes

-Issue History
Date Modified Username Field Change
2010-11-02 10:18 user744 New Issue
2010-11-02 10:24 user744 Note Added: 0005815
2010-11-22 10:55 abma Note Added: 0005911
2010-11-22 17:31 abma Relationship added related to 0002228
2010-12-21 17:16 Kloot Note Added: 0006118
2010-12-21 17:16 Kloot Status new => resolved
2010-12-21 17:16 Kloot Fixed in Version => 0.82.6.1+git
2010-12-21 17:16 Kloot Resolution open => fixed
2010-12-21 17:16 Kloot Assigned To => Kloot
2011-12-02 15:29 user744 Note Added: 0007792
2011-12-02 15:29 user744 Status resolved => feedback
2011-12-02 15:29 user744 Resolution fixed => reopened
2011-12-02 16:03 Kloot Relationship added related to 0001321
2011-12-02 16:05 Kloot Note Added: 0007793
2011-12-02 16:09 user744 Note Added: 0007794
2011-12-02 16:09 user744 Note Edited: 0007794
2011-12-02 16:13 user744 Note Edited: 0007794
2011-12-02 16:14 user744 Note Edited: 0007794
2011-12-02 16:27 user744 Note Added: 0007795
2011-12-02 17:18 Kloot Note Added: 0007796
2011-12-02 17:18 Kloot Status feedback => resolved
2011-12-02 17:18 Kloot Fixed in Version 0.82.7 => 84.0.1
2011-12-02 17:18 Kloot Resolution reopened => fixed
+Issue History