View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002134 | Spring engine | General | public | 2010-09-19 00:07 | 2010-09-29 12:48 |
| Reporter | SirMaverick | Assigned To | hoijui | ||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 0.82.5.1 | ||||
| Summary | 0002134: patch: added PlayerAdded call-in | ||||
| Description | http://github.com/1231e7b84a5de93a/spring/commit/35532220b27a4655d452a3415f27f3979a860be3 | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
playerHandler->AddPlayer() is also used in Game/PreGame.cpp, but I don't think it's needed there. Lua is initialized later so clients will see all (current) players in Spring.GetPlayerList(). |
|
|
the PlayerChanged callin gets already called for new ingame joiners, so is there really a reason for this callin? |
|
|
http://github.com/spring/spring/blob/97dc0b2ff92de76b4cdd710715cd669ba525dcb6/rts/Game/GameServer.cpp#L2154 JoinTeam is only sent for non spectators. A separate call-in would help to write clean code instead of catching every case in one call-in (PlayerChanged). |
|
|
merged into master. thank you for the patch! :-) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-09-19 00:07 | SirMaverick | New Issue | |
| 2010-09-19 00:19 | SirMaverick | Note Added: 0005574 | |
| 2010-09-20 16:31 | jK | Note Added: 0005586 | |
| 2010-09-20 21:09 | SirMaverick | Note Added: 0005595 | |
| 2010-09-29 12:48 | hoijui | Note Added: 0005676 | |
| 2010-09-29 12:48 | hoijui | Status | new => resolved |
| 2010-09-29 12:48 | hoijui | Fixed in Version | => 0.83/0.84 |
| 2010-09-29 12:48 | hoijui | Resolution | open => fixed |
| 2010-09-29 12:48 | hoijui | Assigned To | => hoijui |
