2021-04-22 20:28 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002134Spring engineGeneralpublic2010-09-29 12:48
Assigned Tohoijui 
PrioritynormalSeverityfeatureReproducibilityhave not tried
Product Version 
Target VersionFixed in Version0.82.5.1 
Summary0002134: patch: added PlayerAdded call-in
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files




SirMaverick (reporter)

playerHandler->AddPlayer() is also used in Game/PreGame.cpp, but I don't think it's needed there. Lua is initialized later so clients will see all (current) players in Spring.GetPlayerList().


jK (developer)

the PlayerChanged callin gets already called for new ingame joiners, so is there really a reason for this callin?


SirMaverick (reporter)

JoinTeam is only sent for non spectators.

A separate call-in would help to write clean code instead of catching every case in one call-in (PlayerChanged).


hoijui (reporter)

merged into master. thank you for the patch! :-)

-Issue History
Date Modified Username Field Change
2010-09-19 00:07 SirMaverick New Issue
2010-09-19 00:19 SirMaverick Note Added: 0005574
2010-09-20 16:31 jK Note Added: 0005586
2010-09-20 21:09 SirMaverick Note Added: 0005595
2010-09-29 12:48 hoijui Note Added: 0005676
2010-09-29 12:48 hoijui Status new => resolved
2010-09-29 12:48 hoijui Fixed in Version => 0.83/0.84
2010-09-29 12:48 hoijui Resolution open => fixed
2010-09-29 12:48 hoijui Assigned To => hoijui
+Issue History