View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002099 | Spring engine | General | public | 2010-09-09 01:44 | 2010-11-29 17:49 |
| Reporter | FLOZi | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 0.82.5 | ||||
| Summary | 0002099: No unit healthbars in 0.82+ | ||||
| Description | Exactly what the description says. At first I thought this was an intentional inclusion of kloots converion to lua ( http://github.com/spring/spring/commit/559c64a2f267e356b26845179ce1e6157dcc6496#diff-5 ) but hoijui was surprised when I asked about the missing healthbars, and a quick look through the 0.82 branch code suggests that the code is still there (though I only glanced through UnitDrawer.cpp) and the replacement gadget is certainly absent from the 0.82 base files. This is with normal spring 0.82.5 and 0.82.5.1 (and I believe in all 0.82 releases), haven't yet tried MT. | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
Just checked, healthbars ARE working correctly in 0.82.5.1-MT |
|
|
You need to include my gadget (http://github.com/spring/spring/blob/master/cont/base/springcontent/LuaGadgets/Gadgets/object_statusbars_default.lua ) in your game if you want the default healthbars. |
|
|
You didn't bother actually reading my post, as usual. Your commit is not in the 0.82 branch, and is not supposed to be. Your gadget is not in the 0.82 base files and is not supposed to be. I am aware that it is a solution to this BUG to use your replacement work and currently am doing. That does not however mean that nothing is wrong. |
|
|
"As usual"? What the hell is that supposed to imply? "Your commit is not in the 0.82 branch" ==> except that it effectively is, due to recent fixes by zerver (which I'm not going to touch). Hence my reply. Try making a post free of insults next time, or don't bother. |
|
|
It implies that you read the summary and not the description as a matter of course. I apologise for being personal. At any rate, I don't expect this bug to be fixed, as the behaviour was going to be changed in the long run anyway. That doesn't change the fact that it is a bug! For the record I welcome your work on luafication and I would have welcomed its intended inclusion into 0.82, so long as we were correctly informed of it. This has just been a very unfortunate oversight; as much on our (modders) part for not noticing sooner as the engine devs. |
|
|
No, you deliberately accused me of having a history of misreading your reports by including the "you didn't bother, as usual" parts. For someone pushing for improved content <--> engine dev communication, you'd better leave that kind of crap out. I also don't care how many WORDS you CAPITALIZE, I never once claimed this was NOT a BUG. What I did state (for ANY mod-dev who might be following along, not just you personally) was the simple FACT that the gadget is now needed, NOT the reasons why and NOT whether the change was intentional for 82.* (which, as you have figured out, it WAS NOT). It's your problem if you want to construe that as me ignoring your summary. |
|
|
as noted, only add http://github.com/spring/spring/blob/master/cont/base/springcontent/LuaGadgets/Gadgets/object_statusbars_default.lua to your mod to re-enable healthbars. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-09-09 01:44 | FLOZi | New Issue | |
| 2010-09-09 02:42 | FLOZi | Note Added: 0005486 | |
| 2010-09-09 10:37 | Kloot | Note Added: 0005487 | |
| 2010-09-09 15:58 | FLOZi | Note Added: 0005488 | |
| 2010-09-09 16:16 | Kloot | Note Added: 0005489 | |
| 2010-09-09 16:19 | Kloot | Note Edited: 0005489 | |
| 2010-09-09 18:20 | FLOZi | Note Added: 0005491 | |
| 2010-09-09 18:26 | FLOZi | Note Edited: 0005491 | |
| 2010-09-09 18:43 | FLOZi | Note Edited: 0005491 | |
| 2010-09-09 18:43 | FLOZi | Note Edited: 0005491 | |
| 2010-09-09 19:24 | Kloot | Note Added: 0005492 | |
| 2010-09-09 19:25 | Kloot | Note Edited: 0005492 | |
| 2010-11-29 13:57 | abma | Note Edited: 0005487 | |
| 2010-11-29 17:49 | abma | Note Added: 0006006 | |
| 2010-11-29 17:49 | abma | Status | new => closed |
| 2010-11-29 17:49 | abma | Resolution | open => no change required |
