| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001784 | Spring engine | General | public | 2010-01-08 16:33 | 2010-01-23 11:45 | ||||
| Reporter | slogic | ||||||||
| Assigned To | hoijui | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 0.80.5 | ||||||||
| Target Version | Fixed in Version | 0.81.0.0+git | |||||||
| Summary | 0001784: "ShowPathMap" command should print help in chat instead of executing "showElevation" or "ShowMetalMap" | ||||||||
| Description | "ShowPathMap" command should print help in chat instead of executing "showElevation" or "ShowMetalMap" when used improperly (i.e. no unit was selected). Print smth like "Select any unit before using 'ShowPathMap' command". | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
hoijui (reporter) 2010-01-22 23:19 |
as it is now, the show map path command changes to a state. this state only goes back to normal if you issue the command again, or switch to los-map or metal-map. so if we would add such a message, it would appear every time a unit looses selection, as long as the state is active. in certain use cases, which are valid, this would spam a lot of these messages, for users that really do not need them. i made some commits. it now never shows the metal- or los-map anymore (or at least i was not able to reproduce that). i think it happened because of two returns which should have been breaks. additionally, it now uses a dark-red overlay whenever it is in the draw-path-map state, but no suitable unit is selected, and no build order is currently going on. is that ok for you, slogic? any suggestions? i do not know if the color i have chosen is good. it can be changed very easily. |
|
slogic (reporter) 2010-01-23 11:33 |
i did not know about state switch. anyway what you've done is much better & less confusing. while reading i thought it could be indicated mode switch only in chat area. but other commands (metal spots map, height map) don't do it. so, leave it. |
|
hoijui (reporter) 2010-01-23 11:45 |
using a different solution then bug reporter suggested, but as he is ok with this solution too, we consider it fixed. commit containing the main fix: 2318028a2c1fa5730f2ed9c30d7ccf96a72c20ef about the chat indication... i was thinking about that too, but this command.. in my eyes, is targeted for (mod-)devs mainly.. as it is way to slow to be used when playing. and devs should be able to handle it without the chat indication. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-01-08 16:33 | slogic | New Issue | |
| 2010-01-22 23:19 | hoijui | Note Added: 0004523 | |
| 2010-01-22 23:19 | hoijui | Assigned To | => hoijui |
| 2010-01-22 23:19 | hoijui | Status | new => feedback |
| 2010-01-23 11:33 | slogic | Note Added: 0004525 | |
| 2010-01-23 11:45 | hoijui | Note Added: 0004526 | |
| 2010-01-23 11:45 | hoijui | Status | feedback => resolved |
| 2010-01-23 11:45 | hoijui | Fixed in Version | => 0.81.0.0+git |
| 2010-01-23 11:45 | hoijui | Resolution | open => fixed |
| Issue History |