View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001748 | Spring engine | General | public | 2009-11-30 22:58 | 2010-09-10 17:09 |
| Reporter | SirMaverick | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 0.80.5+git | ||||
| Summary | 0001748: Patch: add ModOption DisconnectEndsGame | ||||
| Description | Add ModOption to define that the game ends when players dropped or leave without resigning. | ||||
| Tags | No tags attached. | ||||
| Checked infolog.txt for Errors | |||||
|
|
http://github.com/1231e7b84a5de93a/spring |
|
|
Patch is bad, because it will not detect game end properly. Its also bad for autohosts because an afk client will make the server run forever. |
|
|
It defines the game end as "as it is now or if all others dropped". "Its also bad for autohosts because an afk client will make the server run forever." Off topic and imo non technical issue. |
|
|
It sets hasController to true, which is just wrong. Also, its not off topic, its a direct consequence of this patch. Additional note: wouldn't a "Continue" button on the Game end screen do a better job? So if you want, you can still continue to play. |
|
|
Setting hasController to true is current state. If the mod option is not active it's still true. "Running forever with afk client" is off topic because it's a result from the current state. This patch does not touch that issue. > Additional note: wouldn't a "Continue" button on the Game end screen do a better job? On autohosts you want a clear defined way when the game stops and not make it an user decision. |
|
|
> On autohosts you want a clear defined way when the game stops and not make it an user decision. Then why want you make it an user decision? Because atm, its an autohost decision to quit the server when the game has ended. |
|
|
More clearly: Not an in game user decision. That mod options defines it before the game starts. (Like com ends etc. - you don't want to change that during the game.) A "Continue" button would be an in game user decision. |
|
|
http://github.com/spring/spring/blob/7790c1075725b0bbf75669e80cb94f7e4263188e/cont/base/springcontent/LuaGadgets/Gadgets/game_end.lua http://springrts.com/phpbb/viewtopic.php?f=14&t=23992&p=447951 game end condition is moving to Lua |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-11-30 22:58 | SirMaverick | New Issue | |
| 2009-11-30 22:59 | SirMaverick | Note Added: 0004394 | |
| 2009-11-30 23:47 | Auswaschbar | Note Added: 0004395 | |
| 2009-11-30 23:47 | Auswaschbar | Note Edited: 0004395 | |
| 2009-12-01 04:39 | SirMaverick | Note Added: 0004396 | |
| 2009-12-01 14:48 | Auswaschbar | Note Added: 0004397 | |
| 2009-12-01 14:56 | Auswaschbar | Note Edited: 0004397 | |
| 2009-12-01 16:25 | SirMaverick | Note Added: 0004398 | |
| 2009-12-01 18:09 | Auswaschbar | Note Added: 0004399 | |
| 2009-12-01 18:34 | SirMaverick | Note Added: 0004400 | |
| 2010-09-10 00:06 | SirMaverick | Note Added: 0005493 | |
| 2010-09-10 17:09 | Kloot | Status | new => closed |
| 2010-09-10 17:09 | Kloot | Resolution | open => no change required |
