View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001725 | Spring engine | General | public | 2009-11-11 15:58 | 2009-11-13 12:14 |
| Reporter | SirMaverick | Assigned To | Auswaschbar | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 0.80.5 | ||||
| Summary | 0001725: long "MyPlayerName" hangs Spring | ||||
| Description | If you set MyPlayerName in script.txt to a very long name, the game does not start. It just shows "Waiting for server to start". | ||||
| Additional Information | e.g. MyPlayerName=unnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamedunnamed; | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
i was not able to reproduce this. just when i forgot to set the Name in the [PLAYERx] section, i got a similar symptom. i tried with the name you gave under Additional Information (around 750 chars), and the game started just fine. GCC debug build on Linux, running in GDB |
|
|
Both scripts show this behavior for me. |
|
|
> GCC debug build on Linux, running in GDB Hangs for me too. |
|
|
For me those scripts just trigger an assertion in debug mode; the Name field of [Player1] needs to match MyPlayerName in [Game]. After setting player 1's name to unnamedunnamedunnamed... as well Springs starts normally. |
|
|
ok, so we found out that it is not about the length of the name already now, just that they differ. one thing we could do is hacing a nicer error message in such a case, and exiting spring. but we can/will never protect agaisnt all errors that could happen when a user manually edits script.txt, so i see it as questionable to be worth doing. what do you want, SirMaverick? |
|
|
With debug build I get "not found in script, rejecting connection attempt". But no assertion triggered. I think the input should be verified and give some message in case of errors. I get no message when the names are different in release build. |
|
|
Spring now quits and give a nice "Unknwon palyer" message when this happens |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-11-11 15:58 | SirMaverick | New Issue | |
| 2009-11-12 12:46 | hoijui | Note Added: 0004309 | |
| 2009-11-12 14:45 | SirMaverick | File Added: script1.txt | |
| 2009-11-12 14:46 | SirMaverick | File Added: script2.txt | |
| 2009-11-12 14:47 | SirMaverick | Note Added: 0004311 | |
| 2009-11-12 15:07 | SirMaverick | Note Added: 0004312 | |
| 2009-11-12 15:29 | Kloot | Note Added: 0004313 | |
| 2009-11-12 16:00 | hoijui | Note Added: 0004314 | |
| 2009-11-12 16:55 | SirMaverick | Note Added: 0004315 | |
| 2009-11-13 12:14 | Auswaschbar | Note Added: 0004320 | |
| 2009-11-13 12:14 | Auswaschbar | Status | new => resolved |
| 2009-11-13 12:14 | Auswaschbar | Resolution | open => fixed |
| 2009-11-13 12:14 | Auswaschbar | Assigned To | => Auswaschbar |
