2020-08-06 09:21 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001365Spring engineGeneralpublic2009-04-01 00:00
Assigned Toimbaczek 
PrioritynormalSeverityminorReproducibilityhave not tried
Product Version0.78.2.1 
Target VersionFixed in Version 
Summary0001365: Hardcoded reclaim speed for features
DescriptionFeature.cpp contains "hardcoded" reclaiming speed of corpses:

(100 + BP of worker) * 0.02 / max(10, reclaimTime of feature)

It should instead be reclaimSpeed of worker..
This equation reduces control mods have over reclaiming.

TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files




imbaczek (reporter)

do you mean the whole expression should change? currently Feature::AddBuildPower uses what is passed to it in Builder.cpp:303:

curReclaim->AddBuildPower(-reclaimSpeed, this))

i do not know any rationale behind the equation you cite, though.


Licho (reporter)

This is some leftover - probably hacked so that it works similar to OTA.
It should only use

part = bp / reclaimTime

where bp is sent to function as -reclaimSpeed

Current equation is just some random hardcoded crap leftover.


imbaczek (reporter)

bp/reclaimTime it is. raised the default reclaimTime 6 times to compensate.

-Issue History
Date Modified Username Field Change
2009-03-29 04:13 Licho New Issue
2009-03-31 16:01 imbaczek Note Added: 0003360
2009-03-31 16:52 Licho Note Added: 0003362
2009-03-31 23:59 imbaczek Note Added: 0003364
2009-03-31 23:59 imbaczek Status new => resolved
2009-03-31 23:59 imbaczek Resolution open => fixed
2009-03-31 23:59 imbaczek Assigned To => imbaczek
+Issue History