| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0001324 | Spring engine | General | public | 2009-02-03 09:01 | 2018-10-20 03:23 | ||||
| Reporter | lurker | ||||||||
| Assigned To | gajop | ||||||||
| Priority | normal | Severity | tweak | Reproducibility | N/A | ||||
| Status | closed | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | 104.0 +git | |||||||
| Summary | 0001324: Make LockLuaUI.txt detection use the CRC32 hash of the filename. | ||||||||
| Description | Right now, there are some easy ways of bypassing LockLuaUI.txt without compiling spring. One is renaming the file in the archive to a precomputed string that has the same CRC32 hash; on such string is on the forums. Another is opening the spring binary in a text editor, searching for "LockLuaUI", and changing a character or two. Both would be stopped by using the hash of the filename instead of a string match, and the chance of collision is not very high in gamedata/ | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Auswaschbar (reporter) 2009-02-04 19:53 |
Why isn't this made as a ModInfo / ModOption / ModRule or something similar? Whouldn't this solve this issues? |
|
tvo (reporter) 2009-03-21 12:49 |
Nope, it's similarly easy to modify any of those files and ensure they keep the same CRC. Lurker's idea sounds good, though maybe a bit tricky to implement. (Don't think the VFS code exposes CRCs of single files anywhere currently.) |
|
gajop (developer) 2018-10-20 03:23 |
LockLuaUI.txt is made obsolete so this issue can be closed. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-02-03 09:01 | lurker | New Issue | |
| 2009-02-03 09:04 | lurker | Summary | Make LockLuaUI detection use the CRC32 hash instead of the filename. => Make LockLuaUI.txt detection use the CRC32 hash of the filename. |
| 2009-02-04 19:53 | Auswaschbar | Note Added: 0003261 | |
| 2009-03-21 12:49 | tvo | Note Added: 0003339 | |
| 2018-10-20 03:23 | gajop | Assigned To | => gajop |
| 2018-10-20 03:23 | gajop | Status | new => closed |
| 2018-10-20 03:23 | gajop | Resolution | open => fixed |
| 2018-10-20 03:23 | gajop | Fixed in Version | => 104.0 +git |
| 2018-10-20 03:23 | gajop | Note Added: 0019420 | |
| Issue History |