0001230: Changing losMipLevel Breaks Gunship Strafing Distance

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001230

Spring engine

General

public

2008-12-30 11:51

2009-01-13 11:14

Reporter

Evil4Zerggin

Assigned To

Kloot

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

0.77b5+svn

Target Version

Fixed in Version

Summary

0001230: Changing losMipLevel Breaks Gunship Strafing Distance

Description

r7219
rts/Sim/Units/CommandAI/MobileCAI.cpp
lines 764, 779

Here, the unit's losRadius is not multiplied by 1 << modInfo.losMipLevel. However, in UnitDefHandler.cpp, the unit's given sightDistance is divided by this number to get the losRadius. Thus, increasing losMipLevel causes gunships to circle unnaturally closer to their targets.

Suggested solutions: Multiply losRadius by (1 << modInfo.losMipLevel) for purposes of determining circling distance, or add an explicit circling distance tag. Unfortunately, I am not sure what includes are necessary for either, which is why I have no patch attached. I should really start building Spring SVN >_>

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes
~0003116 Evil4Zerggin (reporter) 2008-12-30 12:00	Note: If the former solution is picked, replace the "2" with "1 << modInfo.losMipLevel".

~0003131 Kloot (developer) 2009-01-13 11:14	ninja'ed by lurker in 0.78+

Notes

Date Modified	Username	Field	Change
Issue History
2008-12-30 11:51	Evil4Zerggin	New Issue
2008-12-30 12:00	Evil4Zerggin	Note Added: 0003116
2008-12-30 16:12	Kloot	Status	new => assigned
2008-12-30 16:12	Kloot	Assigned To	=> Kloot
2009-01-13 11:14	Kloot	Note Added: 0003131
2009-01-13 11:14	Kloot	Status	assigned => resolved
2009-01-13 11:14	Kloot	Resolution	open => fixed

Issue History