View Issue Details

IDProjectCategoryView StatusLast Update
0001120Spring engineGeneralpublic2008-10-13 17:10
ReporterLicho Assigned ToKloot  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.77b3 
Summary0001120: Aircraft fuel is not working
DescriptionAircrafts are not returning to base.
This breaks especially CA "drop bomb and turn" and also NOTA.

Please revert to old behavior.
TagsNo tags attached.
Checked infolog.txt for Errors

Relationships

has duplicate 0001130 resolvedKloot Aircraft fuel still has problems 

Activities

momfreeek

2008-10-12 17:31

reporter   ~0002817

Last edited: 2008-10-12 17:32

My observed behaviour is that refueling works except when the next order is 'attack'. Bombers that don't kill their final target just circle round the target uselessly. Clear their orders and they'll refuel. I also tested a patrol or move order before attack and they will refuel.

Current behaviour renders nota unplayable.

imbaczek

2008-10-12 22:04

reporter   ~0002826

CA bombers indeed behave weirdly.

Kloot

2008-10-13 15:49

developer   ~0002841

Last edited: 2008-10-13 15:51

traced to r6436


old:

    else if (
        owner->currentFuel <
       (owner->moveType->repairBelowHealth * owner->unitDef->maxFuel) &&

       commandQue.empty() ||
       commandQue.front().id == CMD_PATROL ||
       commandQue.front().id == CMD_FIGHT
   ) {


new:

    else if (
        owner->currentFuel <
       (owner->moveType->repairBelowHealth * owner->unitDef->maxFuel) &&

       (commandQue.empty() ||
        commandQue.front().id == CMD_PATROL ||
        commandQue.front().id == CMD_FIGHT
       )
    ) {

The difference in parentheses means that aircraft will now *only* refuel when they have either NO orders or an active patrol/fight command, but forced refueling should just pull them off of whatever it is they're doing regardless of their orders.

Licho

2008-10-13 15:58

reporter   ~0002842

Yeah, it should ... could you add this () back please? :)

Kloot

2008-10-13 16:06

developer   ~0002843

I just did (locally), but the issue doesn't seem fixed yet (aircraft pick a pad but don't fly to it). I'll get back to you on this ;)

Kloot

2008-10-13 17:10

developer   ~0002846

Refueling should now be functional again. If CA has any gunship-type aircraft that use fuel, it would be a good idea to test those now (I only confirmed fighters cq. bombers were back in action). Reopen should those still be broken.

Issue History

Date Modified Username Field Change
2008-10-12 15:18 Licho New Issue
2008-10-12 17:31 momfreeek Note Added: 0002817
2008-10-12 17:32 momfreeek Note Edited: 0002817
2008-10-12 22:04 imbaczek Note Added: 0002826
2008-10-12 22:04 imbaczek Status new => confirmed
2008-10-13 15:49 Kloot Note Added: 0002841
2008-10-13 15:51 Kloot Note Edited: 0002841
2008-10-13 15:58 Licho Note Added: 0002842
2008-10-13 16:06 Kloot Note Added: 0002843
2008-10-13 17:10 Kloot Note Added: 0002846
2008-10-13 17:10 Kloot Status confirmed => resolved
2008-10-13 17:10 Kloot Resolution open => fixed
2008-10-13 17:10 Kloot Assigned To => Kloot
2008-10-14 09:45 imbaczek Relationship added has duplicate 0001130