View Issue Details

IDProjectCategoryView StatusLast Update
0001076Spring engineGeneralpublic2008-10-11 19:23
ReporterRegret Assigned Toimbaczek  
PrioritynormalSeveritycrashReproducibilityrandom
Status resolvedResolutionfixed 
Product Version0.77b2 
Summary0001076: ground decals crash
DescriptionNo idea whatsoever.

REPRODUCING-HOWTO http://spring.clan-sy.com/phpbb/viewtopic.php?p=311192#p311192
Additional Informatione:/projects/libogg-1.1/src/bitwise.c:447
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/include/c++/bits/stl_tree.h:258
/home/spring/src/winTag_spring_0.77b2/rts/Rendering/GroundDecalHandler.cpp:446
/home/spring/src/winTag_spring_0.77b2/rts/Map/SMF/BFGroundDrawer.cpp:747
/home/spring/src/winTag_spring_0.77b2/rts/Game/Game.cpp:2529
/home/spring/src/winTag_spring_0.77b2/rts/Game/Game.cpp:2778
/home/spring/src/winTag_spring_0.77b2/rts/System/SpringApp.cpp:880
/home/spring/src/winTag_spring_0.77b2/rts/System/SpringApp.cpp:1068
/home/spring/src/winTag_spring_0.77b2/rts/System/Main.cpp:60
/home/spring/src/winTag_spring_0.77b2/rts/System/Main.cpp:122
Action.cpp:0
/home/ron/devel/debian/mingw32-runtime/mingw32-runtime-3.13/build_dir/src/mingw-runtime-3.13-20070825-1/crt1.c:237
/home/ron/devel/debian/mingw32-runtime/mingw32-runtime-3.13/build_dir/src/mingw-runtime-3.13-20070825-1/crt1.c:271
TagsNo tags attached.
Attached Files
infolog.txt (Attachment missing)
20081008_234916_unnamed_0.77b2.sdf (Attachment missing)
infologfromreplay.txt (Attachment missing)
Checked infolog.txt for Errors

Activities

imbaczek

2008-10-09 00:23

reporter   ~0002704

ground decals after all ;p i sense 77b3 soon...

imbaczek

2008-10-09 00:44

reporter   ~0002705

added stacktrace

imbaczek

2008-10-09 01:02

reporter   ~0002707

replay please?

Regret

2008-10-09 11:28

reporter   ~0002718

replay uploaded

imbaczek

2008-10-09 11:35

reporter   ~0002720

one more question - does the replay crash for you?

Regret

2008-10-09 11:52

reporter   ~0002722

Last edited: 2008-10-09 11:58

the replay crashes at random, didn't crash like 5x and then did once

edit:uploaded infolog from replay
edit2: it crashes during loading of the replay, not ingame

imbaczek

2008-10-09 12:04

reporter   ~0002724

Last edited: 2008-10-09 12:06

your second stacktrace is somewhere in Lua, i think it's a different bug, probably 001060. (or a mod issue, i dunno.)

e:/projects/libogg-1.1/src/bitwise.c:447
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:100
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldebug.cpp:612
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldebug.cpp:621
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldebug.cpp:562
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/lvm.cpp:551
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:377
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/lapi.cpp:818
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:119
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:462
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/lapi.cpp:839
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaVFS.cpp:192
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaVFS.cpp:215
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:321
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/lvm.cpp:616
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:377
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/lapi.cpp:818
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:119
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/ldo.cpp:462
/home/spring/src/winTag_spring_0.77b2/rts/lib/lua/src/lapi.cpp:839
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaHandle.h:344
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaHandleSynced.cpp:513
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaHandleSynced.cpp:329
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaHandleSynced.cpp:150
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/include/c++/bits/basic_string.h:288
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/include/c++/bits/basic_string.h:483
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaRules.cpp:109
/home/spring/src/winTag_spring_0.77b2/rts/Lua/LuaRules.cpp:68
/home/spring/src/winTag_spring_0.77b2/rts/Game/Game.cpp:453
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/include/c++/bits/basic_string.h:288
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/include/c++/bits/basic_string.h:483
/home/spring/src/winTag_spring_0.77b2/rts/Game/PreGame.cpp:340
/home/spring/src/winTag_spring_0.77b2/rts/System/SpringApp.cpp:870
/home/spring/src/winTag_spring_0.77b2/rts/System/SpringApp.cpp:1068
/home/spring/src/winTag_spring_0.77b2/rts/System/Main.cpp:60
/home/spring/src/winTag_spring_0.77b2/rts/System/Main.cpp:122
Action.cpp:0
/home/ron/devel/debian/mingw32-runtime/mingw32-runtime-3.13/build_dir/src/mingw-runtime-3.13-20070825-1/crt1.c:237
/home/ron/devel/debian/mingw32-runtime/mingw32-runtime-3.13/build_dir/src/mingw-runtime-3.13-20070825-1/crt1.c:271

Kloot

2008-10-10 01:47

developer   ~0002747

Last edited: 2008-10-10 01:58

Caught it:


Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1232701728 (LWP 14419)]
0x080e418d in DrawBuildingDecal (decal=0xd98b9e8) at rts/Rendering/GroundDecalHandler.cpp:248
248 yv[0] = HEIGHT(zh, xh ); yv[1] = HEIGHT(zh, xh + 1);
(gdb) bt
#0 0x080e418d in DrawBuildingDecal (decal=0xd98b9e8) at rts/Rendering/GroundDecalHandler.cpp:248
#1 0x080db2ce in CGroundDecalHandler::Draw (this=0x91f8b98) at rts/Rendering/GroundDecalHandler.cpp:443
#2 0x080bcfe0 in CBFGroundDrawer::Draw (this=0x8fa4800, drawWaterReflection=false, drawUnitReflection=false, overrideVP=0) at rts/Map/SMF/BFGroundDrawer.cpp:747
0000003 0x081e843f in CGame::DrawWorld (this=0x8c461b8) at rts/Game/Game.cpp:2529
0000004 0x081e9159 in CGame::Draw (this=0x8c461b8) at rts/Game/Game.cpp:2760
0000005 0x084fb59a in SpringApp::Update (this=0xbfa4f168) at rts/System/SpringApp.cpp:880
#6 0x085009b6 in SpringApp::Run (this=0xbfa4f168, argc=2, argv=0xbfa4f244) at rts/System/SpringApp.cpp:1068
#7 0x08525a88 in Run (argc=2, argv=0xbfa4f244) at rts/System/Main.cpp:95
#8 0x08525ae4 in main (argc=226674584, argv=0xe3c5de8) at rts/System/Main.cpp:111

However...

print zh
$1 = 377
(gdb) print xh
$2 = 1228

... are not out of the heightmap bounds for DSD:

(gdb) print gs->mapx
$3 = 1280
(gdb) print gs->mapy
$4 = 640

The computed HM index is (zh * (gs->mapx + 1) + xh) == 484165, which is less than (gs->mapx + 1) * (gs->mapy + 1) (the size of the heightmap array).

EDIT: found and fixed, the HEIGHT() macro was being passed x and z in reverse order.

imbaczek

2008-10-10 01:59

reporter   ~0002748

well done! too late for 77b3 tho, will need 77b4 probably.

Kloot

2008-10-10 02:12

developer   ~0002749

Last edited: 2008-10-10 02:13

I suppose it could still be merged into tags/77b3, dunno how far along the release process is though.

edit: OK, too far ;)

imbaczek

2008-10-10 02:14

reporter   ~0002750

installers and debs are built, uploaded and mirrored; needs only lobby server hot version swap.

Issue History

Date Modified Username Field Change
2008-10-09 00:01 Regret New Issue
2008-10-09 00:01 Regret File Added: infolog.txt
2008-10-09 00:23 imbaczek Note Added: 0002704
2008-10-09 00:44 imbaczek Note Added: 0002705
2008-10-09 00:44 imbaczek Additional Information Updated
2008-10-09 01:02 imbaczek Note Added: 0002707
2008-10-09 01:02 imbaczek Status new => feedback
2008-10-09 01:03 imbaczek Summary random crash is random => ground decals crash
2008-10-09 02:24 imbaczek Severity major => crash
2008-10-09 11:28 Regret File Added: 20081008_234916_unnamed_0.77b2.sdf
2008-10-09 11:28 Regret Note Added: 0002718
2008-10-09 11:35 imbaczek Note Added: 0002720
2008-10-09 11:52 Regret File Added: infologfromreplay.txt
2008-10-09 11:52 Regret Note Added: 0002722
2008-10-09 11:53 Regret Note Edited: 0002722
2008-10-09 11:58 Regret Note Edited: 0002722
2008-10-09 12:04 imbaczek Note Added: 0002724
2008-10-09 12:06 imbaczek Note Edited: 0002724
2008-10-09 23:07 tvo Product Version 0.76b1+svn => 0.77b2
2008-10-10 01:31 imbaczek Description Updated
2008-10-10 01:47 Kloot Note Added: 0002747
2008-10-10 01:53 Kloot Note Edited: 0002747
2008-10-10 01:57 Kloot Note Edited: 0002747
2008-10-10 01:58 Kloot Note Edited: 0002747
2008-10-10 01:59 imbaczek Note Added: 0002748
2008-10-10 02:12 Kloot Note Added: 0002749
2008-10-10 02:13 Kloot Note Edited: 0002749
2008-10-10 02:14 imbaczek Note Added: 0002750
2008-10-11 19:23 imbaczek Status feedback => resolved
2008-10-11 19:23 imbaczek Resolution open => fixed
2008-10-11 19:23 imbaczek Assigned To => imbaczek