2025-08-26 08:41 CEST
  

View Issue Details [ Jump to Notes ] [ Related Changesets ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006395Spring engineGeneralpublic2020-05-17 01:072020-07-03 16:50
Reporterraaar 
Assigned ToKloot 
PriorityimmediateSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
Product Version104.0 +git 
Target VersionFixed in Version 
Summary0006395: 104.0.1-1464-g4f428c8 | lobby message makes game crash
Descriptionmetal factions 1.35, a spectator sent a message that made everyone's game freeze. rejoining doesn't fix it.


the message corresponds to this url:
"""""
https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/d425eb02-4db3-4992-8931-317938cfe21f/d6u8lpa-a1535551-2eed-4fe1-b5f3-757ff1f2ecf6.jpg/v1/fill/w_1024,h_862,q_75,strp/ffvii_heavy_tank_by_fffanatic62583_d6u8lpa-fullview.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOjdlMGQxODg5ODIyNjQzNzNhNWYwZDQxNWVhMGQyNmUwIiwiaXNzIjoidXJuOmFwcDo3ZTBkMTg4OTgyMjY0MzczYTVmMGQ0MTVlYTBkMjZlMCIsIm9iaiI6W1t7ImhlaWdodCI6Ijw9ODYyIiwicGF0aCI6IlwvZlwvZDQyNWViMDItNGRiMy00OTkyLTg5MzEtMzE3OTM4Y2ZlMjFmXC9kNnU4bHBhLWExNTM1NTUxLTJlZWQtNGZlMS1iNWYzLTc1N2ZmMWYyZWNmNi5qcGciLCJ3aWR0aCI6Ijw9MTAyNCJ9XV0sImF1ZCI6WyJ1cm46c2VydmljZTppbWFnZS5vcGVyYXRpb25zIl19.Njdz35463SL_EdwgwMW1EDruNELEwxOkpyWihQt-ofk
"""""
Steps To Reproduce[23:58:40] <ddaannnggeerr> for thet hird tie
[23:58:40] <lmao_who_netMan> Hi zoe
[23:58:42] <ddaannnggeerr> time
[23:58:42] <Shruggoth> Interesting.
[23:58:43] <ddaannnggeerr> https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/d425eb02-4db3-4992-8931-317938cfe21f/d6u8lpa-a1535551-2eed-4fe1-b5f3-757ff1f2ecf6.jpg/v1/fill/w_1024,h_862,q_75,strp/ffvii_heavy_tank_by_fffanatic62583_d6u8lpa-fullview.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOjdlMGQxODg5ODIyNjQzNzNhNWYwZDQxNWVhMGQyNmUwIiwiaXNzIjoidXJuOmFwcDo3ZTBkMTg4OTgyMjY0MzczYTVmMGQ0MTVlYTBkMjZlMCIsIm9iaiI6W1t7ImhlaWdodCI6Ijw9ODYyIiwicGF0aCI6IlwvZlwvZDQyNWViMDItNGRiMy00OTkyLTg5MzEtMzE3OTM4Y2ZlMjFmXC9kNnU4bHBhLWExNTM1NTUxLTJlZWQtNGZlMS1iNWYzLTc1N2ZmMWYyZWNmNi5qcGciLCJ3aWR0aCI6Ijw9MTAyNCJ9XV0sImF1ZCI6WyJ1cm46c2VydmljZTppbWFnZS5vcGVyYXRpb25zIl19.Njdz35463SL_EdwgwMW1EDruNELEwxOkpyWihQt-ofk
[23:58:51] <Shruggoth> Do you see the image-link, raaar?
[23:58:53] <i76700HQ> hmm
[23:58:55] <raaar> not ingame
[23:58:56] <nebula3> <Shruggoth> does this go through from within game
[23:58:58] <raaar> but i do see the error
[23:59:00] <Shruggoth> it does. hmm
[23:59:05] <nebula3> <Shruggoth> test
[23:59:09] <Shruggoth> luaui reload doesn't fix it
[23:59:15] <raaar> lets try rejoining the game
[23:59:16] <Shruggoth> what if I restart
[23:59:18] <Shruggoth> ye
[23:59:25] ** qrtz joined the battle.
[23:59:25] * nebula3 * Hi qrtz (Experienced player), welcome to nebula3 (SPADS 0.12.6a, automated host).
[23:59:25] * nebula3 * For help, say "!help".
[23:59:25] * nebula3 * Want a quick game? Add MFAI bots and start! (currently for land maps only)
[23:59:25] * nebula3 * Type "!map <name>" to pick map. Check map list on www.metalfactions.pt/maps.html.
[23:59:25] * nebula3 * Type "!balance" to split players evenly between opposing teams.
[23:59:25] * nebula3 * For more information visit www.metalfactions.pt! Read the www.metalfactions.pt/instructions.html#10commandments.
[23:59:25] * nebula3 * Find other players on the "mf" chat channel or discord channel : https://discord.gg/GCRsXKd .
[23:59:25] * nebula3 *
[23:59:25] * nebula3 * Type "!promote" to call more players.
[23:59:27] <i76700HQ> ok
[23:59:28] <Shruggoth> nope
[23:59:30] <i76700HQ> i tried rejoining
[23:59:36] <i76700HQ> this time the error was "
[23:59:36] <qrtz> !status
[23:59:36] <lmao_who_netMan> k
[23:59:39] <Shruggoth> it gave me an error that was JUST "string"
[23:59:44] * Warning: user raaar got bonus 30
Additional Informationreplay in attachment
TagsNo tags attached.
Checked infolog.txt for ErrorsYes
Attached Files

-Relationships
+Relationships

-Notes

~0020408

raaar (reporter)

2020-05-17 01:15

 typing this message on single player games does nothing apparently. no crash.

~0020409

raaar (reporter)

2020-05-17 01:40

 we tried on a techA server and it didn't crash. They're using spring 1474.

I'll try the same build ZK is using.

~0020410

raaar (reporter)

2020-05-17 01:59

 we've changed the MF server to "1486-gf266c81_maintenance" (same as ZK) and the crash still happens (attached infolog)

this shows up on infolog:
[f=0000171] <i76700HQ> you want honors
[f=0000212] <i76700HQ> or me?
[f=0000337] [Shruggoth] smh
[f=0000355] <raaar> you type it
[f=0000444] Error: [ProcessRawPacket] discarding incoming invalid packet: ID 48, LEN -2
[f=0000444] Error: [ProcessRawPacket] discarding incoming invalid packet: ID 101, LEN -2
[f=0000444] Error: [ProcessRawPacket] discarding incoming invalid packet: ID 88, LEN -2
[f=0000450] Error: [Game::ClientReadNet][NETMSG_CHAT] exception "Unpack failure (string)"

~0020411

raaar (reporter)

2020-05-17 02:00

 (infolog for the previous message)

~0020412

raaar (reporter)

2020-05-17 02:00

 note that on that crash I had the message separator widget on my game disabled. not sure if relevant.

~0020413

raaar (reporter)

2020-05-17 02:09

 another test which also crashed on build 1486, despite using "/luaui disable"

zip file with replay and infolog attached

~0020428

Google_Frog (reporter)

2020-06-21 03:33

 As far as I'm aware lobby messages are implemented by autohosts.

~0020429

raaar (reporter)

2020-07-02 05:31

 indeed, I'm using spads and if I disable msg forwarding from lobby to game using

!forwardLobbyToGame 0

the messages will no longer trigger the crash.

~0020430

Anonymous (viewer)

2020-07-02 23:30

 Fix 699c8a2d0bad01a995a54ba9f7a224d65a572988 committed to develop branch: fix 0006395, repo: spring changeset id: 37866

~0020436

Anonymous (viewer)

2020-07-02 23:30

 Fix 4ae2dbaa66813c0aa186b1c14fadbffd309666e5 committed to maintenance branch: fix 0006395, repo: spring changeset id: 37867
+Notes

-Related Changesets
spring: develop 699c8a2d
Timestamp: 2020-07-02 11:08:35
Author: rtri
[ Details ] [ Diff ] 		fix 0006395
mod - rts/Game/ChatMessage.cpp [ Diff ] [ File ]
mod - rts/Game/ChatMessage.h [ Diff ] [ File ]
mod - rts/Game/Game.cpp [ Diff ] [ File ]
mod - rts/System/Net/UnpackPacket.h [ Diff ] [ File ]
spring: maintenance 4ae2dbaa
Timestamp: 2020-07-02 11:23:38
Author: rtri
[ Details ] [ Diff ] 		fix 0006395
mod - rts/Game/ChatMessage.cpp [ Diff ] [ File ]
mod - rts/Game/ChatMessage.h [ Diff ] [ File ]
mod - rts/Game/Game.cpp [ Diff ] [ File ]
mod - rts/System/Net/UnpackPacket.h [ Diff ] [ File ]

+Related Changesets

-Issue History
Date Modified Username Field Change
2020-05-17 01:07 raaar New Issue
2020-05-17 01:07 raaar File Added: 20200516_235949_Highway 95 v5_104.0.1-1464-g4f428c8 maintenance.sdfz
2020-05-17 01:15 raaar File Added: infolog_sp_1464_maintenance_msg_freeze_crash.txt
2020-05-17 01:15 raaar Note Added: 0020408
2020-05-17 01:40 raaar Note Added: 0020409
2020-05-17 01:59 raaar Note Added: 0020410
2020-05-17 01:59 raaar File Added: infolog_sp_1486_maintenance_msg_freeze_crash.txt
2020-05-17 02:00 raaar File Added: infolog_sp_1486_maintenance_msg_freeze_crash-2.txt
2020-05-17 02:00 raaar Note Added: 0020411
2020-05-17 02:00 raaar Note Added: 0020412
2020-05-17 02:09 raaar File Added: rep_engine_1486_luaui_disable.zip
2020-05-17 02:09 raaar Note Added: 0020413
2020-06-21 03:33 Google_Frog Note Added: 0020428
2020-07-02 05:31 raaar Note Added: 0020429
2020-07-02 23:30 Changeset attached => spring develop 699c8a2d
2020-07-02 23:30 Anonymous Note Added: 0020430
2020-07-02 23:30 Changeset attached => spring maintenance 4ae2dbaa
2020-07-02 23:30 Anonymous Note Added: 0020436
2020-07-03 16:50 abma Assigned To => Kloot
2020-07-03 16:50 abma Status new => resolved
2020-07-03 16:50 abma Resolution open => fixed
+Issue History