| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0004894 | Spring engine | General | public | 2015-07-08 13:11 | 2015-07-08 16:05 | ||||
| Reporter | cleanrock | ||||||||
| Assigned To | hokomoko | ||||||||
| Priority | normal | Severity | crash | Reproducibility | have not tried | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0004894: crash 99.0.1-93-gcae68eb / Zero-K v1.3.7.3 | ||||||||
| Description | Attaching infolog and demo. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
cleanrock (reporter) 2015-07-08 13:26 |
I tried demo in a debug build but the assert in https://springrts.com/mantis/view.php?id=4892 is triggered. |
|
hokomoko (developer) 2015-07-08 15:24 Last edited: 2015-07-08 15:25 |
asssert(idx < syncedHeightMapDigests.size()) fails: #0 CReadMap::HasHeightMapChanged (this=0x19323db8, lmx=-21, lmy=-3) at C:\programming\spring\rts\Map\ReadMap.cpp:642 #1 0x00c2877b in CReadMap::HeightMapUpdateLOSCheck (this=0x19323db8, rect=...) at C:\programming\spring\rts\Map\ReadMap.cpp:608 #2 0x0063367c in CReadMap::UpdateLOS (this=0x19323db8, rect=...) at C:\programming\spring\rts\Map\ReadMap.cpp:672 0000003 0x00938293 in CLosMap::AddMapSquares (this=0x284a00a8, squares=std::vector of length 52, capacity 381 = {...}, allyteam=0, amount=1) at C:\programming\spring\rts\Sim\Misc\LosMap.cpp:135 0000004 0x00937023 in CLosHandler::LosAdd (this=0x2887a6b8, instance=0x4259f638) at C:\programming\spring\rts\Sim\Misc\LosHandler.cpp:201 0000005 0x00936ecc in CLosHandler::MoveUnit (this=0x2887a6b8, unit=0x42418488, redoCurrent=false) at C:\programming\spring\rts\Sim\Misc\LosHandler.cpp:190 #6 0x0097623c in AMoveType::SlowUpdate (this=0x3f933920) at C:\programming\spring\rts\Sim\MoveTypes\MoveType.cpp:92 #7 0x0095686f in CStrafeAirMoveType::SlowUpdate (this=0x3f933920) at C:\programming\spring\rts\Sim\MoveTypes\StrafeAirMoveType.cpp:673 #8 0x00a2ed28 in CUnit::SlowUpdate (this=0x42418488) at C:\programming\spring\rts\Sim\Units\Unit.cpp:987 #9 0x00a40b3d in CUnitHandler::Update (this=0x22451b60) at C:\programming\spring\rts\Sim\Units\UnitHandler.cpp:271 0000010 0x00425d32 in CGame::SimFrame (this=0x192d4610) at C:\programming\spring\rts\Game\Game.cpp:1578 |
|
hokomoko (developer) 2015-07-08 15:42 Last edited: 2015-07-08 15:43 |
It seems to be https://github.com/spring/spring/commit/943b0b2ebba4a5c8ec7d60478c0ee63a20e44e3c That removed the clamping in LosHandler.cpp leading to negative squares being updated |
|
hokomoko (developer) 2015-07-08 16:03 |
Fix e6d02846b5abcb6e81f3f6248563ea99509fe91e committed to develop branch: Fix 0004894, repo: spring changeset id: 5354 |
|
hokomoko (developer) 2015-07-08 16:05 |
Apparently SafeLosAdd wasn't entirely safe |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-07-08 13:11 | cleanrock | New Issue | |
| 2015-07-08 13:11 | cleanrock | File Added: infolog.txt | |
| 2015-07-08 13:12 | cleanrock | File Added: 20150708_125516_DunePatrol_wip_v03_99.0.1-93-gcae68eb develop.sdf | |
| 2015-07-08 13:26 | cleanrock | Note Added: 0014941 | |
| 2015-07-08 15:24 | hokomoko | Note Added: 0014942 | |
| 2015-07-08 15:25 | hokomoko | Note Edited: 0014942 | View Revisions |
| 2015-07-08 15:42 | hokomoko | Note Added: 0014943 | |
| 2015-07-08 15:43 | hokomoko | Note Edited: 0014943 | View Revisions |
| 2015-07-08 16:03 | hokomoko | Changeset attached | => spring develop e6d02846 |
| 2015-07-08 16:03 | hokomoko | Note Added: 0014944 | |
| 2015-07-08 16:03 | hokomoko | Assigned To | => hokomoko |
| 2015-07-08 16:03 | hokomoko | Status | new => resolved |
| 2015-07-08 16:03 | hokomoko | Resolution | open => fixed |
| 2015-07-08 16:05 | hokomoko | Note Added: 0014945 | |
| 2015-07-08 16:05 | hokomoko | Status | resolved => feedback |
| 2015-07-08 16:05 | hokomoko | Resolution | fixed => reopened |
| 2015-07-08 16:05 | hokomoko | Status | feedback => resolved |
| 2015-07-08 16:05 | hokomoko | Resolution | reopened => fixed |
| Issue History |