2025-07-21 01:29 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004769Spring engineGeneralpublic2015-05-08 19:34
Reportersilentwings 
Assigned TojK 
PrioritynormalSeverityblockReproducibilityalways
StatusresolvedResolutionfixed 
Product Version98.0.1+git 
Target Version99.0Fixed in Version 
Summary0004769: some units don't fire
DescriptionSee demo, with corerad, BA8.17 on DSD.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files

-Relationships
related to 0004774resolvedjK armrl keeps targeting on aircraft which is crashing 
+Relationships

-Notes

~0014424

abma (administrator)

Last edited: 2015-05-03 21:23

View 2 revisions

an other example:

/cheat
/give armrl
/give armpeep 1

(not sure if its the same bug)

~0014425

abma (administrator)

bisected.

last working commit:

https://github.com/spring/spring/commit/59a4d246f4b15b15d9fd20a7483ddca982ab4dee

one of these commits introduced this bug:
https://github.com/spring/spring/commit/9508d0c9ca1936505224dffadcf853d2ce9ec0f0 (breaks compile)
https://github.com/spring/spring/commit/95dbb3604426c7f428b660fdb245cae30d679e08
https://github.com/spring/spring/commit/d3b3b1e2486cdb69c7cf709522573cce8eb6777f
https://github.com/spring/spring/commit/9fc2baad02a275d266542211f01710fe107dae43 (this is the first commit which compiles again)

~0014437

jK (developer)

Fix 9c5cdf1a26937ab0ad5e6b1fab9ff4aa86380d46 committed to develop branch: fix 0004769: some weapons didn't fired (tested with corhurc2), repo: spring changeset id: 4953

~0014438

abma (administrator)

doesn't work for me:

start ba:

/cheat
/give armrl
/give armpeep 1

-> armrl doesn't (automaticly) shoot! with an attack order it shoots!

~0014439

abma (administrator)

maybe better:

the unit ignores the enemy / does nothing until an attack order is given.

~0014440

abma (administrator)

other air units are attacked by armrl, so sth. is special with armpeep.

~0014449

abma (administrator)

oh...

http://imolarpg.dyndns.org/trac/balatest/browser/trunk/units/armpeep.lua#L11
unitdef:
category = ... LIGHTAIRSCOUT ...

http://imolarpg.dyndns.org/trac/balatest/browser/trunk/units/armrl.lua#L143
weapondef:
badtargetcategory = ... LIGHTAIRSCOUT ...


so, this is ok?

~0014450

Google_Frog (reporter)

Units with bad target cats should still fire. Just not if there are other targets available.

~0014451

jK (developer)

Fix b4158711c33bb75579f5de017c5fea2ef4d169cf committed to develop branch: fix 0004769: some units don't fire, repo: spring changeset id: 4964
+Notes

-Issue History
Date Modified Username Field Change
2015-05-03 20:38 silentwings New Issue
2015-05-03 20:38 silentwings File Added: 20150503_193327_DeltaSiegeDry_98.0.1-604-g19c4df4 develop.sdf
2015-05-03 20:45 abma Target Version => 99.0
2015-05-03 21:23 abma Note Added: 0014424
2015-05-03 21:23 abma Note Edited: 0014424 View Revisions
2015-05-03 21:36 abma Note Added: 0014425
2015-05-03 21:36 abma Assigned To => jK
2015-05-03 21:36 abma Status new => assigned
2015-05-03 21:42 abma Severity major => block
2015-05-07 18:17 jK Changeset attached => spring develop 9c5cdf1a
2015-05-07 18:17 jK Note Added: 0014437
2015-05-07 18:17 jK Status assigned => resolved
2015-05-07 18:17 jK Resolution open => fixed
2015-05-07 19:55 abma Note Added: 0014438
2015-05-07 19:55 abma Status resolved => new
2015-05-08 01:33 abma Note Added: 0014439
2015-05-08 01:37 abma Note Added: 0014440
2015-05-08 01:46 abma Relationship added related to 0004774
2015-05-08 08:34 abma Note Added: 0014449
2015-05-08 08:43 abma Status new => feedback
2015-05-08 09:22 Google_Frog Note Added: 0014450
2015-05-08 10:00 abma Status feedback => new
2015-05-08 19:34 jK Changeset attached => spring develop b4158711
2015-05-08 19:34 jK Note Added: 0014451
2015-05-08 19:34 jK Status new => resolved
+Issue History