| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003784 | Spring engine | General | public | 2013-05-07 08:48 | 2013-05-07 20:17 | ||||
| Reporter | jK | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | 95.0 | Fixed in Version | |||||||
| Summary | 0003784: GroundMoveType spams repaths | ||||||||
| Description | causing commit is: https://github.com/spring/spring/commit/8ee2f8272d030f04341ef171dd18c7eb70c106b1 ideas: i limit repaths to SlowUpdates? ii is the repath needed at all? when I comment out those lines, everything seems to work fine. | ||||||||
| Steps To Reproduce | /give 100 armsolar /give 100 corak 1 -> RequestPath eats >70% cpu time | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
 Notes |
|
|
Kloot (developer) 2013-05-07 11:00 Last edited: 2013-05-07 11:01 |
For me cpu usage doesn't rise above 20% with that test and the peak loads are caused by ak's trying to reach "inner" solars to which no valid path exists, which is a problem that won't go away without that commit. If anything the issue with this specific commit is also not that it repaths but that new paths can trigger the same condition again each frame (with the default PFS) which should be impossible _by design_. Regardless I will add a repath-counter to throttle requests a bit. |
|
cleanrock (reporter) 2013-05-07 16:48 |
Fyi, I deleted my notes because i was testing on a debug build. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-05-07 08:48 | jK | New Issue | |
| 2013-05-07 11:00 | Kloot | Note Added: 0010664 | |
| 2013-05-07 11:00 | Kloot | Note Edited: 0010664 | View Revisions |
| 2013-05-07 11:01 | Kloot | Note Edited: 0010664 | View Revisions |
| 2013-05-07 16:41 | Kloot | Relationship added | has duplicate 0003693 |
| 2013-05-07 16:48 | cleanrock | Note Added: 0010667 | |
| 2013-05-07 20:17 | Kloot | Status | new => resolved |
| 2013-05-07 20:17 | Kloot | Resolution | open => fixed |
| 2013-05-07 20:17 | Kloot | Assigned To | => Kloot |
| Issue History |