| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002779 | Spring engine | General | public | 2011-11-26 17:57 | 2011-12-04 12:39 | ||||
| Reporter | Licho | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 84.0 | ||||||||
| Target Version | Fixed in Version | 85.0 | |||||||
| Summary | 0002779: Demo file name reported by dedi server does not match reality | ||||||||
| Description | Dedicated server reports invalid demo file name for example: For example dedi server reports 20111126_041350_Red Comet_84.0.sdf but actual filename is http://springdemos.licho.eu/20111126_041350_unnamed_84.0.sdf (even after game ends). Might be related to the fact that we have to kill dedi server because it wont end (other reported issue). | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
||||||
|
||||||
 Relationships |
| Notes |
|
|
abma (administrator) 2011-11-26 23:22 |
side-effect of 0002767. the demo file is renamed when spring is shutdown. -> if it doesn't shutdown correctly, the demofile isn't renamed correctly... |
|
abma (administrator) 2011-11-27 06:01 |
maybe a workaround in springie would be, to check for both filenames? (afaik both are reported to infolog.txt) this would also work, if spring-dedicated crashes... |
|
abma (administrator) 2011-11-27 06:02 |
imo this can't be fixed, will be indirectly fixed by 0002767 |
|
Licho (reporter) 2011-11-27 12:17 |
Just a question - is there a reason it works this way? Why does it use different filename and rename after the game... It knows the map from the very start it could name it correctly from there (or delay creation until then) |
|
abma (administrator) 2011-11-27 13:36 Last edited: 2011-11-27 13:37 |
If i understood the code right, a connecting client receives first some data before the filename is known. To fix that, the client would have to buffer data in memory and then start writing to demofile after the filename is known. https://github.com/spring/spring/blob/develop/rts/System/LoadSave/DemoRecorder.cpp#L101 afaik "Player ... connected" is a message, that is recorded before the mapname is known. -> could be fixed, but imo to many work for a very small improvement with some drawbacks (if it crashes before something is written to demofile -> no demofile -> harder to debug). other stuff would be much more important, like 0002767 :) correct? |
|
Licho (reporter) 2011-11-27 14:37 |
In this case its dedicated server it knows the map from start because it has the script... On clients it should be buffered, on dedi server its known and does not have to be buffered even... |
|
abma (administrator) 2011-11-27 22:53 |
hm, looks like not correct, thanks Kloot! https://github.com/spring/spring/commit/f9aca8bfbd5b8496f323f6c2b423cafda73f6b18 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-26 17:57 | Licho | New Issue | |
| 2011-11-26 23:21 | abma | Relationship added | related to 0002767 |
| 2011-11-26 23:22 | abma | Note Added: 0007721 | |
| 2011-11-27 06:01 | abma | Note Added: 0007724 | |
| 2011-11-27 06:02 | abma | Note Added: 0007725 | |
| 2011-11-27 06:02 | abma | Status | new => resolved |
| 2011-11-27 06:02 | abma | Resolution | open => not fixable |
| 2011-11-27 06:02 | abma | Assigned To | => abma |
| 2011-11-27 12:17 | Licho | Note Added: 0007728 | |
| 2011-11-27 12:17 | Licho | Status | resolved => feedback |
| 2011-11-27 12:17 | Licho | Resolution | not fixable => reopened |
| 2011-11-27 13:36 | abma | Note Added: 0007730 | |
| 2011-11-27 13:37 | abma | Note Edited: 0007730 | |
| 2011-11-27 14:11 | Kloot | Status | feedback => assigned |
| 2011-11-27 14:11 | Kloot | Assigned To | abma => Kloot |
| 2011-11-27 14:37 | Licho | Note Added: 0007732 | |
| 2011-11-27 21:26 | Kloot | Status | assigned => resolved |
| 2011-11-27 21:26 | Kloot | Fixed in Version | => 84.0.1 |
| 2011-11-27 21:26 | Kloot | Resolution | reopened => fixed |
| 2011-11-27 22:53 | abma | Note Added: 0007734 | |
| 2011-12-04 12:39 | hoijui | Fixed in Version | 84.0.1 => 85.0 |
| Issue History |