View Revisions: Issue #4717
[ All Revisions ] [ Back to Issue ]
| Summary | 0004717: reading of SMF files seems unrealible to corrupted / broken files | ||
|---|---|---|---|
| Revision | 2015-03-24 14:01 by abma | ||
| Description | https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFFormat.h#L77 -> https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFMapFile.cpp#L23 it seems, maybe i missed it: - missing range checks: all int vars could be negative - missing check if an read error happened - missing buffer length check in CSMFMapFile::ReadInfoMap, buffer could be to short (=mem corruption), it is passed from unitsync |
||
| Revision | 2015-03-24 13:57 by abma | ||
| Description | https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFFormat.h#L77 -> https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFMapFile.cpp#L23 it seems, maybe i missed it: - missing range checks: all int vars could be negative - missing check if an read error happened |
||
| Revision | 2015-03-24 13:57 by abma | ||
| Description | https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFFormat.h#L77 -> https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFMapFile.cpp#L23 it seems, maybe i missed it: - missing range checks: all int vars could be negative - missing check if an read error happened |
||