| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0004717 | Spring engine | General | public | 2015-03-24 13:57 | 2015-03-24 14:01 | ||||||||
| Reporter | abma | ||||||||||||
| Assigned To | |||||||||||||
| Priority | normal | Severity | major | Reproducibility | have not tried | ||||||||
| Status | new | Resolution | open | ||||||||||
| Product Version | |||||||||||||
| Target Version | 98.0.1+git | Fixed in Version | |||||||||||
| Summary | 0004717: reading of SMF files seems unrealible to corrupted / broken files | ||||||||||||
| Description | https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFFormat.h#L77 -> https://github.com/spring/spring/blob/develop/rts/Map/SMF/SMFMapFile.cpp#L23 it seems, maybe i missed it: - missing range checks: all int vars could be negative - missing check if an read error happened - missing buffer length check in CSMFMapFile::ReadInfoMap, buffer could be to short (=mem corruption), it is passed from unitsync | ||||||||||||
| Additional Information | https://springrts.com/phpbb/viewtopic.php?f=12&t=33309 | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Checked infolog.txt for Errors | |||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
| There are no notes attached to this issue. |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-03-24 13:57 | abma | New Issue | |
| 2015-03-24 13:57 | abma | Target Version | => 98.0.1+git |
| 2015-03-24 13:57 | abma | Description Updated | View Revisions |
| 2015-03-24 14:01 | abma | Description Updated | View Revisions |
| Issue History |