site: Forum Today at/Yesterday at timestamps

site: Forum Today at/Yesterday at timestamps

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

site: Forum Today at/Yesterday at timestamps

Post by AF »

I propose that the phpbb forum in the new site be modified to show timestamps differently.

If today was july 9th, instead of showing Last post at 9am july 9th, it should display Last post Today at 9am. Thus it should substitute dates for Yesterday and Today where appropriate.

The phpbb mod is simple and well tested, requiring no database calls or table changes of any kind.Should a security issue arise the changed files can be replaced with the security fixes, and the mod can be restored at a later date with no ill effects inbetween.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

I would suggest to add all phpbb changes you like to make into one overall plan. That way it's easy to just cut and paste the plan into the site documentation.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

phpbb changes can sometimes be quite tedious when you have 10 or 20 todo. I would prefer to do the little ones instead as an afternmoon of copy paste isnt very palatable..
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

Well, alright do it the way you like.

Maybe you can add that an upgrade to phpbb3 would also not be a problem with this mod.

And how will this work out with different languages?
I like to add language files to phpbb to complement the language work in the rest of the site but will this mod break things there?
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

The mod uses the language files, itll just need 2-3 lines appended to the end.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

I presume the language files way is the most logical way to do it.

This topic is now a week old, there is little response, what are you going to do?
Presume that my blessing is enough support?
Or are you going to ask around for others to comment on this?

I personally think this is to small a change to get people interested enough to comment, they probably agree or don't care. A good way to get more feedback next time would be to include more stuff in the plan from the start, but we already discussed that before here.
Tobi
Spring Developer
Posts: 4598
Joined: 01 Jun 2005, 11:36

Post by Tobi »

It will improve the usability of the forum IMHO, so +1
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

http://www.phpbb.com/mods/db/index.php? ... ib_id=1181

Theres the mod if anybody wants to go ahead and make an svn patch but do post here before you do so i know not to do the same work twice.
User avatar
smoth
Posts: 22309
Joined: 13 Jan 2005, 00:46

Post by smoth »

that mod is tiny. it was one of TONS of mods I applied to my forum.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

I updated the board to 2.0.22 and applied the mod while at it. Documentation is also committed.
We have to check now if it's applied correctly, but that has to wait as I like to make a few other changes to make "community news", "project news" and "highlights" work.

So I will get back to this to finish the process.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

As the code is running in the dev. env. it's time to finish up the process.

AF if you look at the messageboard is it working like you needed it? Happy with it?
Also look at the documentation (part 4.3.3) is this good enough? Fnordia, if you read this, you may also like to comment on this as you maintain the server. With a update to phpbb you would have to re-implement this mod.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

The changes ahve not been applied.

There is no Today at or Yesterday. I should not be able to see todays date on that forum.

I see no evidence that this mod has been applied in any shape or form.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

Guess what... :-) that's because all posts are from last week. Make a new post and it should show up.

Login details can be found in the General Discussion forum.
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

when I try to login I get error cant establish connection to localhost.

Its not a site error its in a firefox error page so firefox is trying to load from localhost

Meanwhile I'm actually logged in now when I go back to the index page
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

ok it works
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

Documentation is ok to?

Hmm, that localhost error could be a phpbb configuration error but I don't know.. anyway it's not that relevant to this topic as it's not related to the mod (I presume) and the mod itself is applied and works.

If the documentation is ok then we followed the dev process from start to end.
You started this topic Aug 8, it's finished Sep 4, I'm a bit in a limbo about this, is this reasonable?
Considering the things that happened:
- It's discussed by you, me, Tobi and smoth.
- The plan is put forward and prepared by you and implemented by me.
- It's documented.
- It's tested.

The time it takes kills the "development rush" as you can't get on with it when you have the idea in your head and like to get it implemented. The other side is that the process was actually shared by two people in this case. That did make it possible as you were to busy with other things to implement it, I on the other hand did not like to push the political part where support for and feedback on the plan is gathered. While visa versa we did.
What do you think about the process as we used it here?
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

I would say that the guidelines on how to develop the site and the change log of what has been added to the site don't belong in the same document.

I would also say that referring to all under 16 as children is not correct. I personally am not aware of a single 14, 15 or 16 year old who would not consider that offensive or odd.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

Maybe your right.. now that it has become a ratter large document but then I would still like to split it up into multiple odt's that get linked into the general documentation.

As for the definition of children I guess that's true to. To me everything below 18 would need some special thought as they can't make independent choices without their parents approval (signature). Also many things like internet banking, international payments or credit cards are off-limits in a lot of cases. In many country's it's illegal to expose them to sensual explicit material. And a lot of younger children do play games but can't read/write English as they start to learn it at age 12-14 or so (if they actually manage to learn the language beyond the basics). All this has its consequences for us as a project.

Other then that,.. I sure like it that you read through the whole document. :-) But I only need your "approval" for this plan on section 4.3.3
User avatar
AF
AI Developer
Posts: 20687
Joined: 14 Sep 2004, 11:32

Post by AF »

I had internet banking at the age fo 12, along with a bank card I could use online in my name.

As for language barrier thats a moot point as the same can be said of anyone of any age from a non english speaking country.

On top of that the fact that in some countries children cant see explicit material by law, is a moot point too, swiftspear stated very clearly the site and lboby should be PG13 so explicit material would be a moderation offence.
User avatar
Tim Blokdijk
Posts: 1242
Joined: 29 May 2005, 11:18

Post by Tim Blokdijk »

Yhea, so what is your point? Write a better text for the "children" part if you like.
Other then that were going off-topic here. :?
Post Reply

Return to “Engine”