
I enabled debug mode on http://replays-test.springrts.com/ so that it will dump the complete login request (you may wish to change your password before that).
Moderator: Moderators
Code: Select all
BadCharm won!
* Server stopped (running time: 14 minutes and 13 seconds)
* unknown, inactive or invalid *uploader* account
Error: Discarding incoming invalid packet: ID 69, LEN -2
Error: Discarding incoming invalid packet: ID 168, LEN -2
Error: Discarding incoming invalid packet: ID 146, LEN -2
Error: Discarding incoming invalid packet: ID 242, LEN -2
Error: Discarding incoming invalid packet: ID 0, LEN -2
thats a 94.1 bug... http://springrts.com/mantis/view.php?id=3826Jools wrote: Another thing, although maybe unrelated to the replay script: sometimes spads endgame script will be running for a very long time, it only seems to exit about 5 minutes after the game ended. And sometimes it reports the game was undecided although there was a winner. Maybe there is some loop that it gets trapped into? If it matters, there are some packets that are usually discarded like in this output:
Error: Discarding incoming invalid packet: ID 242, LEN -2
FFA on SaltrockColonyV2 01.11.2013 01.11.2013 SpringTanksHost1Internal Server Error (500)
The server encountered an internal error or misconfiguration and was unable to complete your request.
Maybe it should only block once it has checked if the existing entry really works to download?Uploaded replay already exists: "FFA on SaltrockColonyV2"
Bug on the server, your config is fine.Webserver wrote:Internal Server Error (500)
If the player left while a match was running, the demofile will be incomplete and a reupload will be allowed.knorke wrote:Maybe it should only block once it has checked if the existing entry really works to download?
Also, but that is just a guess: Does it check just by gameID?
What if a player uploads a replay where he left in middle of game and another player tries to upload the complete replay?
Ah yes... I'm also annoyed by that... but it's not so easy: what about a player with color black: black text in a black box? If anyone knows of an algorithm to detect dark and light colors (so the opposite can be used as text/box), please tell me...albator wrote:1) Colors like while yellow, etc are a pain to read for name. I suggest to make the color being inside a bounding box, the font color staying black
Nice idea!albator wrote:2) For player who belongs to HoF, give a spacial tag/rank/cups/icon, so you can see it in the replays.
Sorry - the site has moved to SLDB provided rank data, and that brings a certain privacy model.albator wrote:3) Some player have like 1000 games played but you can only see a few: e.g. http://replays.admin-box.com/player/868791/. It would nice to have access to them as well. Actually, It would be nice to have access to other account so you can see other nicknames, or to list all of them for each account .
My personal political believes are anti-nationalistic. I will not put flags on a website if there is not a good reason. Comparison of nationalistic clans is the worst reason I can imagine.albator wrote:4) I still think flag should be included cause that is a pain to look at it in the lobby. If you wanna check, that is doable anyway in the lobby, so I don't see the problem.
Plus you could make some nice stats involving countries and make some kind of country ranking or HoF for team game for example which would put some more dynamics and team play behavior in the team game community. Of course that is pure conjunctures :D
IMO you are right about this. As the values shown on the site are the values from SLDB, please discuss it with bibim or "the community" (bibim will listen). I think you're right, but again it's not my place to decide alone.albator wrote:5) for people appearing everywhere in all HoF, just automatically enable their stats being showed accurate everywhere otherwise that is kinda hypocrite since they can be found in HoF and nowhere else. Other option would be to remove accurate stats in HoF (and also when msg SLDB but I guess I should ask that to bibim)
Wanted since almost a year: https://github.com/dansan/spring-replay-site/issues/37 ... will do when I have the time... should be an easy thing with some stars like on imdb :)albator wrote:6) Allow user connected to vote and rank the replays from 1 to 10 to give an idea of how good it is so players wanted to watch some have some clue.
Maybe weigh the votes both by TS and ingame-time. They you can make a HoF of replay. Best would be to be able to grade the replay just after the game vote in spads but that is another story.
The awards don't make any sense atm, so wouldn't implement that just yet.dansan wrote: I want to remodel the whole replay-page anyway, to get more space for the players, as I want to show the BA awards, etc. Then a color-box besides the players name could be the easiest solution. I'm just very occupied atm, and have given the website low priority.
You're right, showing detailed stats for users having privacyMode enabled isn't a good thing imo. Player stats should only be available to the player himself in this case, otherwise it's like showing the exact ratings, as these data allow identifying the player easily.albator wrote:3) Some player have like 1000 games played but you can only see a few: e.g. http://replays.admin-box.com/player/868791/.
This would basically make the privacyMode useless, and I think allowing privacy is important as long as it has no impact on balance quality (especially because we have no technical way to really disable privacy anyway, as players could always recreate accounts changing ip etc., so best is to allow them keeping privacy without impacting balance).albator wrote:It would nice to have access to them as well. Actually, It would be nice to have access to other account so you can see other nicknames, or to list all of them for each account
Showing accurate stats for everyone in HoF is a deliberate choice, I don't really see the hypocrisy in that. Imo it's a good thing because players in top 20 shouldn't be ashamed of their ranking anyway, and it adds some competitive information for these players (allowing them to know how far they are from the next player above them etc.). Also, it doesn't really break privacy because as you explained it is the only place where their exact stats are shown, so you can't associate this HoF data for sure to the other accounts of the player.albator wrote:5) for people appearing everywhere in all HoF, just automatically enable their stats being showed accurate everywhere otherwise that is kinda hypocrite since they can be found in HoF and nowhere else. Other option would be to remove accurate stats in HoF (and also when msg SLDB but I guess I should ask that to bibim)
Imo it's OK, because the win/loss ratio kind of explains the TS, without revealing the players identity. And the players performance identifies him as smurf anyway.bibim wrote:You're right, showing detailed stats for users having privacyMode enabled isn't a good thing imo.albator wrote:3) Some player have like 1000 games played but you can only see a few: e.g. http://replays.admin-box.com/player/868791/.
How would you do that? There is no search function to look for a specific win/loss count or ratio or any statistics.bibim wrote:Player stats should only be available to the player himself in this case, otherwise it's like showing the exact ratings, as these data allow identifying the player easily.