Build failures with new default compiler flags in Intrepid

[YokoZar]

https://wiki.ubuntu.com/CompilerFlags

Intrepid added the following flags:
-D_FORTIFY_SOURCE=2
-Wformat -Wformat-security
-Wl,-z,relro

And, using the same package as builds in Ubuntu Hardy, it fails to build from source. It's likely that the first flag is the culprit, however I haven't tested disabling it yet.

Is there a possibility of these compiler flags causing desyncs if enabled on one build and not another?

[Tobi]

I don't think any of them would cause desync.

[YokoZar]

I'm not sure the build failures are due to the new compiler flags, actually. I found no difference when disabling them.

Here are two different build logs. The first is a successful one, in Hardy:

Hardy build log

The next is a failed one, in Intrepid, with newer versions of packages:

Intrepid build log

Here's where it begins to blow up:

Code: Select all

g++ -o build/rts/System/Object.o -c -fsingle-precision-constant -frounding-math -fsignaling-nans -mieee-fp -O2 -pipe -fno-strict-aliasing -fvisibility=hidden -mfpmath=387 -pthread -fsingle-precision-constant -frounding-math -fsignaling-nans -mieee-fp -O2 -pipe -fno-strict-aliasing -fvisibility=hidden -mfpmath=387 -pthread -D_SZ_ONE_DIRECTORY -D_GNU_SOURCE=1 -D_REENTRANT -DSTREFLOP_X87 -DSYNCCHECK -DNO_AVI -DDIRECT_CONTROL_ALLOWED -Irts -Irts/System -Irts/lib/luabind -Irts/lib/lua/include -I/usr/include -I/usr/include/GL -I/usr/include/freetype2 -I/usr/include/SDL -I/usr/include/ogg -I/usr/include/vorbis -I/usr/include/python2.5 -I/usr/include/python2.4 -I/usr/include/java rts/System/Object.cpp
In file included from /usr/include/c++/4.3/ext/hash_set:64,
                 from rts/System/creg/STL_Set.h:7,
                 from rts/System/Object.cpp:8:
/usr/include/c++/4.3/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated.
g++ -o build/rts/System/Matrix44f.o -c -fsingle-precision-constant -frounding-math -fsignaling-nans -mieee-fp -O2 -pipe -fno-strict-aliasing -fvisibility=hidden -mfpmath=387 -pthread -fsingle-precision-constant -frounding-math -fsignaling-nans -mieee-fp -O2 -pipe -fno-strict-aliasing -fvisibility=hidden -mfpmath=387 -pthread -D_SZ_ONE_DIRECTORY -D_GNU_SOURCE=1 -D_REENTRANT -DSTREFLOP_X87 -DSYNCCHECK -DNO_AVI -DDIRECT_CONTROL_ALLOWED -Irts -Irts/System -Irts/lib/luabind -Irts/lib/lua/include -I/usr/include -I/usr/include/GL -I/usr/include/freetype2 -I/usr/include/SDL -I/usr/include/ogg -I/usr/include/vorbis -I/usr/include/python2.5 -I/usr/include/python2.4 -I/usr/include/java rts/System/Matrix44f.cpp
g++ -o build/rts/System/AutohostInterface.o -c -fsingle-precision-constant -frounding-math -fsignaling-nans -mieee-fp -O2 -pipe -fno-strict-aliasing -fvisibility=hidden -mfpmath=387 -pthread -fsingle-precision-constant -frounding-math -fsignaling-nans -mieee-fp -O2 -pipe -fno-strict-aliasing -fvisibility=hidden -mfpmath=387 -pthread -D_SZ_ONE_DIRECTORY -D_GNU_SOURCE=1 -D_REENTRANT -DSTREFLOP_X87 -DSYNCCHECK -DNO_AVI -DDIRECT_CONTROL_ALLOWED -Irts -Irts/System -Irts/lib/luabind -Irts/lib/lua/include -I/usr/include -I/usr/include/GL -I/usr/include/freetype2 -I/usr/include/SDL -I/usr/include/ogg -I/usr/include/vorbis -I/usr/include/python2.5 -I/usr/include/python2.4 -I/usr/include/java rts/System/AutohostInterface.cpp
rts/System/AutohostInterface.cpp: In member function 'void AutohostInterface::SendPlayerJoined(unsigned char, const std::string&) const':
rts/System/AutohostInterface.cpp:81: error: 'strncpy' was not declared in this scope
rts/System/AutohostInterface.cpp: In member function 'void AutohostInterface::SendPlayerChat(unsigned char, const std::string&) const':
rts/System/AutohostInterface.cpp:104: error: 'strncpy' was not declared in this scope
scons: *** [build/rts/System/AutohostInterface.o] Error 1
scons: building terminated because of errors.
make: *** [build-stamp] Error 2

[YokoZar]

Latest svn seems to compile fine, so I guess this isn't an issue as long as we make a release by September.