Handling adjacent tabs

Handling adjacent tabs

For the discussion of infrastructure improvements and changes.

Moderator: Moderators

Post Reply
MetalSucker
Posts: 98
Joined: 22 Sep 2014, 20:29

Handling adjacent tabs

Post by MetalSucker » 23 Jun 2015, 12:34

I just got hit with:

Code: Select all

BATTLEOPENED[SPACE]3672[SPACE]0[SPACE]0[SPACE]nicb1[SPACE]211.27.83.106[SPACE]8452[SPACE]32[SPACE]1[SPACE]0[SPACE]1970750745[SPACE]spring[TAB]94.1[TAB]Coastal[TAB][TAB]PrivateTest[TAB]NOTA 1.xxx
(2 tabs before PrivateTest)
...and messed up my parsing, first crash in 12+ hours.

BATTLEOPENED battleID type natType founder ip port maxPlayers passworded rank mapHash {engineName} {engineVersion} {map} {title} {gameName}

This shouldn't happen, right?
0 x

abma
Spring Developer
Posts: 3540
Joined: 01 Jun 2009, 00:08

Re: Handling adjacent tabs

Post by abma » 25 Jun 2015, 09:58

just ignore these battles, this is "fixed" here by ignoring such invalid commands:
https://github.com/spring/uberserver/co ... 47b31184b1

("OPENBATTLE" has a more strict checking)

but not applied yet due to more testing needed of lobbyserver as there are some huge changes done.
0 x

MetalSucker
Posts: 98
Joined: 22 Sep 2014, 20:29

Re: Handling adjacent tabs

Post by MetalSucker » 25 Jun 2015, 10:33

Code: Select all

UPDATEBATTLEINFO[space]3835[space]0[space]0[space]1481928328[space]Comet[space]Catcher[space]Redux[space]v2[TAB]
UPDATEBATTLEINFO spectatorCount locked mapHash {mapName}

Another one(but this could actually be protocol-valid), [tab] at the end
0 x

abma
Spring Developer
Posts: 3540
Joined: 01 Jun 2009, 00:08

Re: Handling adjacent tabs

Post by abma » 25 Jun 2015, 10:39

tab at the end imo is invalid... added to the todo: https://github.com/spring/uberserver/issues/177
0 x

Post Reply

Return to “Infrastructure Development”

cron