Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Discuss the source code and development of Spring Engine in general from a technical point of view. Patches go here too.

Moderator: Moderators

Post Reply
User avatar
Silentwings
Moderator
Posts: 3686
Joined: 25 Oct 2008, 00:23

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by Silentwings »

Re: viewtopic.php?f=64&t=33869

What is the reason/use case for AllowSpectatorJoin=true? (note for the unfamiliar: the tag probably doesn't do what you think it does).

The only things I could think of that were close were future multiplayer missions and ingame lobbies, but isn't there the glaring insecurity of impersonification? I can't see how anything could be done about that. Am curious since I hope one day to make multiplayer missions...
hokomoko
Spring Developer
Posts: 592
Joined: 02 Jun 2014, 00:46

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by hokomoko »

player a hosts a game
player b tries to join this game after it started as a spec.
player b can't do that because AllowSpectatorJoin is false.
User avatar
Silentwings
Moderator
Posts: 3686
Joined: 25 Oct 2008, 00:23

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by Silentwings »

Ok, it does apply to spectators trying to join user hosted games late, and I agree that should be possible in an ideal world. (For autohosts, it's not needed - they should set it to false, and specs will still be able to midgame join, see link in OP)

But imo its not very useable, for that or for my ideas, whilst it allows impersonation. If there's an autohost involved, maybe it can help authenticate, if not, afaics we're left trying to authenticate in lua, which is wtf.
abma
Spring Developer
Posts: 3704
Joined: 01 Jun 2009, 00:08

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by abma »

would it make sense if "anonymous" users get a automatic name, like anonymous1,anonymous2,... ?

the only purpose of this setting is that anyone can join a running game.
hokomoko
Spring Developer
Posts: 592
Joined: 02 Jun 2014, 00:46

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by hokomoko »

maybe append "(spec)" to their name?
abma
Spring Developer
Posts: 3704
Joined: 01 Jun 2009, 00:08

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by abma »

hokomoko wrote:maybe append "(spec)" to their name?
i would prefer a prefix. not sure about what, maybe a tilde? i.e.

Code: Select all

~username
on irc that meant a user wasn't running ident.
hokomoko
Spring Developer
Posts: 592
Joined: 02 Jun 2014, 00:46

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by hokomoko »

Sounds good.
User avatar
Silentwings
Moderator
Posts: 3686
Joined: 25 Oct 2008, 00:23

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by Silentwings »

Sounds like a reasonable precaution.

But still, afaics this leaves an ingame lobby & similar trying to authenticate in lua with ~no info, or just not at all, and that's not going to hold water.
gajop
Moderator
Posts: 3044
Joined: 05 Aug 2009, 20:42

Re: https://springrts.com/phpbb/viewtopic.php?f=64&t=33869

Post by gajop »

I don't understand how multiplayer missions and ingame lobbies are affected by this.
I think there are far bigger issues that need resolving, that this one doesn't even fall under my radar, but still I feel I should know.
Post Reply

Return to “Engine”