View Issue Details

IDProjectCategoryView StatusLast Update
0000759Spring engineGeneralpublic2008-10-14 22:31
Reporterimbaczek Assigned ToAuswaschbar  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Fixed in Version0.76b1+svn 
Summary0000759: 76b1: players joined under wrong names/identities
Descriptionsee attached replay.
TagsNo tags attached.
Attached Files
080102-Zeus05_A-0.76b1.sdf (Attachment missing)
080102-Zeus05_A-0.76b1-0.sdf (Attachment missing)
player id issue, from KDRs perspective 080102-Zeus05_A-0.76b1.sdf (Attachment missing)
messed-up-player-numbers-080117-Victoria Crater-0.76b1.sdf (Attachment missing)
wrong_ids.zip (Attachment missing)
Checked infolog.txt for Errors

Activities

KDR_11k

2008-01-02 18:47

reporter   ~0001650

I was in that game and was ignored by the server (it said my ID was 0).

Auswaschbar

2008-01-02 19:01

reporter   ~0001653

Last edited: 2008-01-02 19:26

What do you mean by different identities? Different compared with what? Please take a look at the startscript (open demofile with a texteditor) and check if the names are set right, if not its a lobby bug.

KDR_11k:
edit: Does startpos-setting and playing works for you? And was player 0 able to to anything?
edit2: It didn't say your ID was 0, it said that Peet's ID was 3
and ofcourse you was spec because it was set in the script

imbaczek

2008-01-02 19:30

reporter   ~0001654

different compared to what they were in the lobby - eg. KDR was a spec and he ended up being Peet (IIRC.) Also, the game complained that it received messages from player X but really from player Y.

Auswaschbar

2008-01-02 20:12

reporter   ~0001657

Last edited: 2008-01-02 20:13

Did you checked the script? Is it correct?

The demofile says this:
SYSTEMMSG: Player: 255 Msg: Client connected on slot 3
SYSTEMMSG: Player: 255 Msg: Player [GG]Otherside joined as 1
PLAYERNAME: Playernum: 1 Name: [GG]Otherside
SYSTEMMSG: Player: 255 Msg: Server: Warning got playername msg from 0 claiming to be from 3
SYSTEMMSG: Player: 255 Msg: Player baczek joined as 4
PLAYERNAME: Playernum: 4 Name: baczek
CHAT: Player: 1 Msg: uh oh
SYSTEMMSG: Player: 255 Msg: Player [tN]Ray joined as 2
PLAYERNAME: Playernum: 2 Name: [tN]Ray
CHAT: Player: 1 Msg: not good
CHAT: Player: 1 Msg: not good at all
SYSTEMMSG: Player: 255 Msg: Player KDR_11k joined as 3
PLAYERNAME: Playernum: 3 Name: KDR_11k

Do you mean KDR got assigned to number 0, and thus his chatmessage were rejected?

@KDR:
It would be really helpfull if you could either post an infolog or your version of the demofile.

imbaczek

2008-01-02 20:22

reporter   ~0001659

also, peet was the host, we'll have to ask him for the demo, too.

P3374H

2008-01-02 20:26

reporter   ~0001660

I checked script.txt btw, it was fine.

betalord

2008-01-05 01:28

reporter   ~0001717

Perhaps this has to do with recent modification that Tobi added that automatically eliminates the gaps in team / player numbers (this is what tasclient does manually, but now spring does it too so it's no longer necessary). I don't know the details, but this looks like it could be related.

LordMatt

2008-01-05 06:58

reporter   ~0001719

This happened to me sometimes with .75b2. Particularly the first time I launched spring in a while and had to enter in my sudo pw (running a separate x server with custom xorg.conf requires you to be root). Sometimes I might be a little slow to get it entered and my spring to launch, and I would get this bug when I finally connected.

Auswaschbar

2008-01-05 12:54

reporter   ~0001723

Could you please reproduce this in latest revision since I added some verbosity to CGameServer which might help tracking down this issue.
And please test which player got assigned to which number/name ingame.

KDR_11k

2008-01-05 13:38

reporter   ~0001725

When I'm spec, this confusion happens and I'm casted as a player I still can't set start positions. Also I can see both team's positions, my Spring propbably knows I'm a spec. If I get mistaken for the host I can kick people BTW.

That "Warning: got message from 0 claiming to be from 3" thing appeared every time I tried to say anything in that match where I got ignored.

I'll see if I can find the demo.

KDR_11k

2008-01-05 20:41

reporter   ~0001738

We had this in a game, then we decided to reorder the team ids so there were no gaps and the problem disappeared.

tvo

2008-01-17 21:17

reporter   ~0001855

Added another demo that shows this problem.

Auswaschbar: Any clue what the cause is already?

Auswaschbar

2008-01-17 23:06

reporter   ~0001857

I know exactly what is causing this error:
One client sends a wrong NETMSG_ATTEMTCONNECT, he got a wrong playernumber from the server in return and may screw up all numbers from people who join later.

But I'm afraid I have no idea where this wrong number comes from...

satirik

2008-01-19 14:09

reporter   ~0001869

maybe it's a script.txt problem ?

ILMTitan

2008-02-21 05:35

reporter   ~0001977

In CNetProtocol::InitClient and CNetProtocol::InitLocalClient,
CNet::InitClient is called with wantedNumber, and stores what the number ended up being in myNum. It then calls SendAttemptConnect with wantedNumber. Should that be myNum instead?

imbaczek

2008-04-26 13:29

reporter   ~0002166

added replay, script.txt and infolog.txt from what i think is a related problem.

acidd_uk

2008-04-28 23:03

reporter   ~0002181

Can't you force the server to assign player numbers when players connect based on their name, rather than each player having their own local script.txt file that may be different for whatever reason?

Auswaschbar

2008-04-28 23:30

reporter   ~0002182

Playernames are read by playernumber, so anyone who send a wrong number would also send a wrong name.

But this may be a lobby bug because it can be solved by assigning player numbers without gaps (which has been lobby standard a while ago).

Auswaschbar

2008-10-14 22:31

reporter   ~0002897

lobby issue.

Issue History

Date Modified Username Field Change
2008-01-02 18:45 imbaczek New Issue
2008-01-02 18:45 imbaczek File Added: 080102-Zeus05_A-0.76b1.sdf
2008-01-02 18:47 KDR_11k Note Added: 0001650
2008-01-02 19:01 Auswaschbar Note Added: 0001653
2008-01-02 19:20 Auswaschbar Note Edited: 0001653
2008-01-02 19:26 Auswaschbar Note Edited: 0001653
2008-01-02 19:30 imbaczek Note Added: 0001654
2008-01-02 20:12 Auswaschbar Note Added: 0001657
2008-01-02 20:13 Auswaschbar Note Edited: 0001657
2008-01-02 20:22 imbaczek Note Added: 0001659
2008-01-02 20:26 P3374H Note Added: 0001660
2008-01-02 20:28 P3374H File Added: 080102-Zeus05_A-0.76b1-0.sdf
2008-01-05 01:28 betalord Note Added: 0001717
2008-01-05 06:58 LordMatt Note Added: 0001719
2008-01-05 12:54 Auswaschbar Note Added: 0001723
2008-01-05 13:38 KDR_11k Note Added: 0001725
2008-01-05 13:41 KDR_11k File Added: player id issue, from KDRs perspective 080102-Zeus05_A-0.76b1.sdf
2008-01-05 20:41 KDR_11k Note Added: 0001738
2008-01-17 21:16 tvo File Added: messed-up-player-numbers-080117-Victoria Crater-0.76b1.sdf
2008-01-17 21:17 tvo Note Added: 0001855
2008-01-17 23:06 Auswaschbar Note Added: 0001857
2008-01-19 14:09 satirik Note Added: 0001869
2008-02-21 05:35 ILMTitan Note Added: 0001977
2008-04-26 13:29 imbaczek File Added: wrong_ids.zip
2008-04-26 13:29 imbaczek Note Added: 0002166
2008-04-28 23:03 acidd_uk Note Added: 0002181
2008-04-28 23:30 Auswaschbar Note Added: 0002182
2008-10-14 22:31 Auswaschbar Status new => resolved
2008-10-14 22:31 Auswaschbar Fixed in Version => 0.76b1+svn
2008-10-14 22:31 Auswaschbar Resolution open => fixed
2008-10-14 22:31 Auswaschbar Assigned To => Auswaschbar
2008-10-14 22:31 Auswaschbar Note Added: 0002897