2019-12-09 10:18 CET

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0000707Spring engineLinuxpublic2007-12-18 12:57
Reportermalric 
Assigned Totvo 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0000707: Configuration fails in case zip has version like "x.y" and not "x.y.z"
DescriptionFor a certain version format of zip, the configure script will not be able to determine zip exists and will fail.
Additional InformationTo reproduce:

- give the following command :

 scons configure debug=2

- the stack trace obtained:

AttributeError: 'NoneType' object has no attribute 'group':
  File "/home/vladms/projects/spring/trunk/SConstruct", line 33:
    env = Environment(tools = ['default', 'rts'], toolpath = ['.', 'rts/build/scons'])
  File "//usr/lib/scons-0.97/SCons/Environment.py", line 794:
    apply_tools(self, tools, toolpath)
  File "//usr/lib/scons-0.97/SCons/Environment.py", line 137:
    env.Tool(tool)
  File "//usr/lib/scons-0.97/SCons/Environment.py", line 1340:
    tool(self)
  File "//usr/lib/scons-0.97/SCons/Tool/__init__.py", line 157:
    apply(self.generate, ( env, ) + args, kw)
  File "/home/vladms/projects/spring/trunk/rts/build/scons/rts.py", line 418:
    config.configure(env, conf_dir=os.path.join(env['builddir'], 'sconf_temp'))
  File "/home/vladms/projects/spring/trunk/rts/build/scons/config.py", line 333:
    check_zip_version(env, conf)
  File "/home/vladms/projects/spring/trunk/rts/build/scons/config.py", line 19:
    version = re.search('Zip [0-9]\.[0-9]\.?[0-9]', version).group()

- what my zip says

Copyright (C) 1990-1999 Info-ZIP
Type 'zip "-L"' for software license.
Zip 2.3 (November 29th 1999). Usage:
zip [-options] [-b path] [-t mmddyyyy] [-n suffixes] [zipfile list] [-xi list]
  The default action is to add or replace zipfile entries from list, which
  can include the special name - to compress standard input.
  If zipfile and list are omitted, zip compresses stdin to stdout.
  -f freshen: only changed files -u update: only changed or new files
  -d delete entries in zipfile -m move into zipfile (delete files)
  -r recurse into directories -j junk (don't record) directory names
  -0 store only -l convert LF to CR LF (-ll CR LF to LF)
  -1 compress faster -9 compress better
  -q quiet operation -v verbose operation/print version info
  -c add one-line comments -z add zipfile comment
  -@ read names from stdin -o make zipfile as old as latest entry
  -x exclude the following names -i include only the following names
  -F fix zipfile (-FF try harder) -D do not add directory entries
  -A adjust self-extracting exe -J junk zipfile prefix (unzipsfx)
  -T test zipfile integrity -X eXclude eXtra file attributes
  -y store symbolic links as the link instead of the referenced file
  -R PKZIP recursion (see manual)
  -e encrypt -n don't compress these suffixes



- I would suggest to modify the expression that checks for zip to something like:

Zip [0-9]\.*[0-9]*\.*[0-9]

- the patch is attached.
TagsNo tags attached.
Checked infolog.txt for Errors
Attached Files
  • patch file icon config.patch (394 bytes) 2007-12-14 01:39 -
    Index: config.py
    ===================================================================
    --- config.py	(revision 4995)
    +++ config.py	(working copy)
    @@ -16,7 +16,7 @@
     	finally:
     		f.close()
     	if version:
    -		version = re.search('Zip [0-9]\.[0-9]\.?[0-9]', version).group()
    +		version = re.search('Zip [0-9]\.*[0-9]*\.*[0-9]*', version).group()
     		print version, "found"
     	else:
     		print "not found"
    
    patch file icon config.patch (394 bytes) 2007-12-14 01:39 +

-Relationships
+Relationships

-Notes

~0001514

tvo (reporter)

Committed, thank you!
+Notes

-Issue History
Date Modified Username Field Change
2007-12-14 01:39 malric New Issue
2007-12-14 01:39 malric Status new => assigned
2007-12-14 01:39 malric Assigned To => tvo
2007-12-14 01:39 malric File Added: config.patch
2007-12-18 12:57 tvo Assigned To tvo =>
2007-12-18 12:57 tvo Assigned To => tvo
2007-12-18 12:57 tvo Status assigned => resolved
2007-12-18 12:57 tvo Resolution open => fixed
2007-12-18 12:57 tvo Note Added: 0001514
+Issue History