| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006128 | Spring engine | Lua | public | 2019-02-05 18:53 | 2019-02-21 12:30 | ||||
| Reporter | Doo | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | low | Severity | feature | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 104.0 +git | ||||||||
| Target Version | Fixed in Version | 104.0 +git | |||||||
| Summary | 0006128: [Feature Request] Add number timeout arg to Spring.GiveOrderToUnit(unitID, cmdID, cmdParams, cmdOptions) | ||||||||
| Description | I understand there is already a built-in timeout system for unit commands to be dropped if they haven't been performed after that time. It is a very useful parameter for AIs, but as i've seen, isn't available via Spring.GiveOrderToUnit. Is it possible to add that parameter so that commands given by LuaAIs via Spring.GiveOrderToUnit can properly be cancelled if they are unreachable/take too long to be performed? --> https://github.com/spring/spring/blob/9c3eb80fc73cf5269c8fdbe80785e58de47661fe/rts/Lua/LuaUtils.cpp#L949 --> https://github.com/spring/spring/blob/9c3eb80fc73cf5269c8fdbe80785e58de47661fe/rts/Lua/LuaUtils.cpp#L1002-L1035 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
AF (reporter) 2019-02-05 19:20 |
PR at https://github.com/spring/spring/pull/427, is how I'd imagine it'd be implemented |
|
Kloot (developer) 2019-02-05 21:10 |
done. |
|
Kloot (developer) 2019-02-21 12:30 |
Fix be999101be20d10fe46ce6921d7ec7d88ccdece5 committed to develop branch: fix 0006128, repo: spring changeset id: 11419 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-02-05 18:53 | Doo | New Issue | |
| 2019-02-05 19:20 | AF | Note Added: 0019703 | |
| 2019-02-05 21:10 | Kloot | Assigned To | => Kloot |
| 2019-02-05 21:10 | Kloot | Status | new => resolved |
| 2019-02-05 21:10 | Kloot | Resolution | open => fixed |
| 2019-02-05 21:10 | Kloot | Fixed in Version | => 104.0 +git |
| 2019-02-05 21:10 | Kloot | Note Added: 0019704 | |
| 2019-02-21 12:29 | Kloot | Changeset attached | => spring develop be999101 |
| 2019-02-21 12:30 | Kloot | Note Added: 0019753 | |
| Issue History |