| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0006102 | Spring engine | General | public | 2018-12-16 06:15 | 2018-12-16 19:34 | ||||
| Reporter | gajop | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | normal | Severity | tweak | Reproducibility | sometimes | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0006102: Disable Hang Detection in specific code sections | ||||||||
| Description | I have some sections in SpringBoard which often trigger WatchDog's hang detection. It's not possible to work around it with Spring.ClearWatchDogTimer(), as it can also happen during a single callout, e.g. "gl.RenderToTexture(totalMapTexture, gl.SaveImage, 0, 0, Game.mapSizeX, Game.mapSizeZ, texturePath)". Setting HangTimeout to -1 (disabling it) is a hacky workaround, as I'd like the watchdog to work in most other cases. Would it be possible to provide a better inteface, such as Spring.SetWatchDogEnabled(bool), Spring.ExecuteWithoutWatchdog(function() ... end), or something along those lines..? Ideally we'd have some of these tasks 'execute in the background', but this isn't exactly trivial. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Kloot (developer) 2018-12-16 19:20 |
Fix 19e204180e140633a3511206aa60c2b52a926a52 committed to develop branch: fix 0006102, repo: spring changeset id: 11220 |
|
Kloot (developer) 2018-12-16 19:21 |
Fix 7e258fc8ea124ee38f5b4ac7bcca68a960de57d0 committed to maintenance branch: fix 0006102, repo: spring changeset id: 11221 |
|
Kloot (developer) 2018-12-16 19:24 Last edited: 2018-12-16 19:34 |
Spring.ClearWatchDogTimer accepts a second argument to disable HD now, but note that it is your responsibility to reset this after use. |
| Notes |
| Related Changesets |
|||
|
spring: develop 19e20418
Timestamp: 2018-12-16 19:20:31 Author: Kloot [ Details ] [ Diff ] |
fix 0006102 | ||
| mod - rts/Lua/LuaUnsyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Platform/Watchdog.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Platform/Watchdog.h | [ Diff ] [ File ] | ||
|
spring: maintenance 7e258fc8
Timestamp: 2018-12-16 19:20:31 Author: Kloot [ Details ] [ Diff ] |
fix 0006102 | ||
| mod - rts/Lua/LuaUnsyncedCtrl.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Platform/Watchdog.cpp | [ Diff ] [ File ] | ||
| mod - rts/System/Platform/Watchdog.h | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-12-16 06:15 | gajop | New Issue | |
| 2018-12-16 19:20 | Kloot | Changeset attached | => spring develop 19e20418 |
| 2018-12-16 19:20 | Kloot | Note Added: 0019612 | |
| 2018-12-16 19:20 | Kloot | Assigned To | => Kloot |
| 2018-12-16 19:20 | Kloot | Status | new => resolved |
| 2018-12-16 19:20 | Kloot | Resolution | open => fixed |
| 2018-12-16 19:21 | Kloot | Changeset attached | => spring maintenance 7e258fc8 |
| 2018-12-16 19:21 | Kloot | Note Added: 0019613 | |
| 2018-12-16 19:24 | Kloot | Note Added: 0019614 | |
| 2018-12-16 19:34 | Kloot | Note Edited: 0019614 | View Revisions |
| Issue History |