2019-08-24 11:43 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0006038Spring engineGeneralpublic2018-09-09 11:09
Reportersprung 
Assigned ToKloot 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version104.0 +git 
Target VersionFixed in Version 
Summary0006038: noExplode weapons do not obey SetUnitWeaponState("range")
DescriptionnoExplode weapons use range from the original weapon def so will not pierce beyond it if extended. DGun weapontype is particularly affected because it checks collisions every frame so the check happens right at the edge of the range (other weapons can continue but not pierce).
Steps To ReproduceGet two noExplode weapons with 1000 range, one LaserCannon and one DGun, extend them both to 3000 with SetUnitWeaponState.

Spawn a target at 2500 distance, shoot it. The LaserCannon reaches and impacts it for 1 frame (not piercing further), the DGun disappears right at 1000.

Spawn something in the line of fire at 500 distance (while shooting the 2500 one). Both weapons pierce it (impacting for N frames as long as inside hitvolume), and the LaserCannon still reaches the further target.

Spawn something in the line of fire at 1500 distance (still targeting 2500). Now the LaserCannon impacts the 1500 target for 1 frame and won't reach the 2500 one at all.
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0019343

Kloot (developer)

Fix 93b22d069897c80901857b3aa450c255724bf9d9 committed to develop branch: fix 0006038
move tempNum up to WorldObject, repo: spring changeset id: 10665

~0019344

Kloot (developer)

Fix 8cdf8309eb28f3baddcda8448dfcf4518be490e2 committed to maintenance branch: fix 0006038
move tempNum up to WorldObject, repo: spring changeset id: 10666
+Notes

-Related Changesets
spring: develop 93b22d06
Timestamp: 2018-09-09 02:15:18
Author: Kloot
Details ] Diff ]
fix 0006038
move tempNum up to WorldObject
mod - rts/Sim/Objects/SolidObject.cpp Diff ] File ]
mod - rts/Sim/Objects/SolidObject.h Diff ] File ]
mod - rts/Sim/Objects/WorldObject.cpp Diff ] File ]
mod - rts/Sim/Objects/WorldObject.h Diff ] File ]
mod - rts/Sim/Projectiles/Projectile.cpp Diff ] File ]
mod - rts/Sim/Projectiles/Projectile.h Diff ] File ]
mod - rts/Sim/Projectiles/ProjectileParams.h Diff ] File ]
mod - rts/Sim/Projectiles/WeaponProjectiles/StarburstProjectile.cpp Diff ] File ]
mod - rts/Sim/Projectiles/WeaponProjectiles/WeaponProjectile.cpp Diff ] File ]
mod - rts/Sim/Projectiles/WeaponProjectiles/WeaponProjectile.h Diff ] File ]
spring: maintenance 8cdf8309
Timestamp: 2018-09-09 02:15:18
Author: Kloot
Details ] Diff ]
fix 0006038
move tempNum up to WorldObject
mod - rts/Sim/Objects/SolidObject.cpp Diff ] File ]
mod - rts/Sim/Objects/SolidObject.h Diff ] File ]
mod - rts/Sim/Objects/WorldObject.cpp Diff ] File ]
mod - rts/Sim/Objects/WorldObject.h Diff ] File ]
mod - rts/Sim/Projectiles/Projectile.cpp Diff ] File ]
mod - rts/Sim/Projectiles/Projectile.h Diff ] File ]
mod - rts/Sim/Projectiles/ProjectileParams.h Diff ] File ]
mod - rts/Sim/Projectiles/WeaponProjectiles/StarburstProjectile.cpp Diff ] File ]
mod - rts/Sim/Projectiles/WeaponProjectiles/WeaponProjectile.cpp Diff ] File ]
mod - rts/Sim/Projectiles/WeaponProjectiles/WeaponProjectile.h Diff ] File ]

+Related Changesets

-Issue History
Date Modified Username Field Change
2018-09-08 17:48 sprung New Issue
2018-09-09 11:08 Kloot Changeset attached => spring develop 93b22d06
2018-09-09 11:08 Kloot Note Added: 0019343
2018-09-09 11:08 Kloot Assigned To => Kloot
2018-09-09 11:08 Kloot Status new => resolved
2018-09-09 11:08 Kloot Resolution open => fixed
2018-09-09 11:09 Kloot Changeset attached => spring maintenance 8cdf8309
2018-09-09 11:09 Kloot Note Added: 0019344
+Issue History