0006026: double SDL include

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0006026

Spring engine

Linux

public

2018-08-08 07:55

2018-09-22 17:26

Reporter

hoijui

Assigned To

Kloot

Priority

normal

Severity

block

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

104.0 +git

Target Version

Fixed in Version

104.0 +git

Summary

0006026: double SDL include

Description

on latest springrts git (104.0.1-1022-gfb81c05c1), on a fresh compile with CMake from scratch on my Debian testing, i get lots of errors because of two times included SDL headers, excerpt here:

/home/user/src/spring/include/SDL2/SDL_stdinc.h:118:17: error: redeclaration of ‘SDL_FALSE’
     SDL_FALSE = 0,
                 ^
In file included from /usr/include/SDL2/SDL_mouse.h:31:0,
                 from /home/user/src/spring/rts/Game/InMapDraw.cpp:3:
/usr/include/SDL2/SDL_stdinc.h:141:5: note: previous declaration ‘SDL_bool SDL_FALSE’
     SDL_FALSE = 0,
     ^~~~~~~~~

looks like it includes SDL once from spring sources and once from the system.

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes

~0019281

abma (administrator)

2018-08-09 10:53

did the headguards change in a system installed SDL2?

https://github.com/spring/spring/blob/develop/include/SDL2/SDL_stdinc.h#L29

#define _SDL_stdinc_h

(still the cmake needs to be cleaned up so only on include path is used)

Notes

Date Modified	Username	Field	Change
Issue History
2018-08-08 07:55	hoijui	New Issue
2018-08-09 10:53	abma	Note Added: 0019281
2018-09-22 17:26	Kloot	Assigned To	=> Kloot
2018-09-22 17:26	Kloot	Status	new => resolved
2018-09-22 17:26	Kloot	Resolution	open => fixed
2018-09-22 17:26	Kloot	Fixed in Version	=> 104.0 +git

Issue History