| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005841 | Spring engine | General | public | 2017-11-20 07:23 | 2018-02-08 18:00 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | Kloot | ||||||||
| Priority | low | Severity | feature | Reproducibility | N/A | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 104.0 +git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005841: Set the colour of area selection for custom commands | ||||||||
| Description | As far as I can tell there is currently no way to set the area colour for custom commands. The areas always draw with a semitransparent grey. I am able to change everything else about a command (cursor, queue drawing colour), see here for an example: https://github.com/ZeroK-RTS/Zero-K/commit/6947a99cc81923c3e9d3c83f9223a871412e98d0#diff-836b8904ef2c837fc0536a895bd49ad1R19 | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
sprung (reporter) 2017-11-21 13:36 |
https://github.com/spring/spring/blob/ca5552ca61340e49d6b1bdda505c8b62f300e38d/rts/Game/UI/GuiHandler.cpp#L3537-L3552 |
|
Kloot (developer) 2017-12-09 23:39 |
Fix a42f68db896c88cde8183b6e9a60288cb5443998 committed to develop branch: fix 0005841, repo: spring changeset id: 9358 |
|
Google_Frog (reporter) 2018-02-08 06:55 |
I don't think this is complete. As far as I can tell the change (https://github.com/spring/spring/commit/a42f68db896c88cde8183b6e9a60288cb5443998) made it possible to modify the grey colour that is used for all custom command areas. What I wanted was to be able to set the colour for each custom command. I have a custom command with a yellow cursor and stippled line so I want to make the area yellow. I have another custom command with blue cursor and line so I want to make its area blue. |
|
Kloot (developer) 2018-02-08 10:28 Last edited: 2018-02-08 10:32 |
I don't think you read the commit comments. |
|
Google_Frog (reporter) 2018-02-08 11:15 |
I see that customArea colour can be changed. How do I make multiple different custom colours for area commands? |
|
Kloot (developer) 2018-02-08 11:42 |
Spring.SetCustomCommandDrawData |
|
Google_Frog (reporter) 2018-02-08 11:45 |
Are you saying that I should call Spring.LoadCmdColorsConfig between each application of Spring.SetCustomCommandDrawData? I already use Spring.SetCustomCommandDrawData and it appears to have no effect on custom areas. |
|
Kloot (developer) 2018-02-08 12:23 |
That might be a bug in area-command drawing then, I'll check the code again later. |
|
Kloot (developer) 2018-02-08 18:00 |
Fix e10e7d86aee0b399e90472a9f5463c698fa9fd78 committed to develop branch: fix 0005841 add., repo: spring changeset id: 9554 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-11-20 07:23 | Google_Frog | New Issue | |
| 2017-11-21 13:36 | sprung | Note Added: 0018651 | |
| 2017-12-09 23:39 | Kloot | Changeset attached | => spring develop a42f68db |
| 2017-12-09 23:39 | Kloot | Note Added: 0018686 | |
| 2017-12-09 23:39 | Kloot | Assigned To | => Kloot |
| 2017-12-09 23:39 | Kloot | Status | new => resolved |
| 2017-12-09 23:39 | Kloot | Resolution | open => fixed |
| 2018-02-08 06:55 | Google_Frog | Status | resolved => feedback |
| 2018-02-08 06:55 | Google_Frog | Resolution | fixed => reopened |
| 2018-02-08 06:55 | Google_Frog | Note Added: 0018786 | |
| 2018-02-08 10:28 | Kloot | Note Added: 0018787 | |
| 2018-02-08 10:32 | Kloot | Note Edited: 0018787 | View Revisions |
| 2018-02-08 11:15 | Google_Frog | Note Added: 0018789 | |
| 2018-02-08 11:15 | Google_Frog | Status | feedback => assigned |
| 2018-02-08 11:42 | Kloot | Note Added: 0018790 | |
| 2018-02-08 11:45 | Google_Frog | Note Added: 0018791 | |
| 2018-02-08 12:23 | Kloot | Note Added: 0018792 | |
| 2018-02-08 18:00 | Kloot | Changeset attached | => spring develop e10e7d86 |
| 2018-02-08 18:00 | Kloot | Note Added: 0018793 | |
| 2018-02-08 18:00 | Kloot | Status | assigned => resolved |
| 2018-02-08 18:00 | Kloot | Resolution | reopened => fixed |
| Issue History |