0005773: Different and hardly predictible behaviour of planes when alt < cruisealt

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005773

Spring engine

General

public

2017-09-19 22:32

Reporter

Doo

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Product Version

103.0

Target Version

Fixed in Version

Summary

0005773: Different and hardly predictible behaviour of planes when alt < cruisealt

Description

When alt < cruisealt it seems planes do not behave the same way as when alt>cruisealt.

More precisely, it seems that maxPitch/maxBank = 0 when alt < cruisealt
The behaviour then suddenly change when cruise alt is reached.

It seems to be related to the landing sequence being triggered by alt<cruisealt

https://github.com/spring/spring/blob/develop/rts/Sim/MoveTypes/AAirMoveType.cpp

[[
    if (distSq <= radiusSq || (distSq < landRadiusSq && localAltitude < wantedHeight + radius)) {
        SetState(AIRCRAFT_LANDED);
        owner->SetVelocityAndSpeed(UpVector * owner->speed)
]]

Maybe consider switching from a single cutoff = cruisealt to a more nuanced behaviour between a landing (no bank, no pitch) behaviour and a cruising (pitch and bank allowed) depending on the % of cruisealt reached ?

Another possibility would be to set the cutoff lower so that statechanges won't be spammed on small alt variations around cruisealt.

Steps To Reproduce

Land/takeoff a plane (non hover)
Sometimes when getting too low/close to ground on ground slopes

Additional Information

No need for a replay as it is easily reproductible, but in case you'd be having troubles, the behaviour is pretty obvious on ba:test.

Date Modified	Username	Field	Change
Issue History
2017-09-19 22:32	Doo	New Issue

Relationships

Notes
There are no notes attached to this issue.