View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000572 | Spring engine | General | public | 2007-07-28 15:07 | 2007-08-13 18:22 |
| Reporter | imbaczek | Assigned To | imbaczek | ||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000572: [patch] build once | ||||
| Description | by popular demand: - if a factory is set on repeat and the user alt-leftclicks a unit, it gets inserted right behind the current order and is only built once. behavior of alt-click when repeat is off is unchanged (ie. replace the currently built unit.) | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Checked infolog.txt for Errors | |||||
|
|
You bumped from 8 bits to 32 bits for all command options for this feature when the 3 lower bits aren't being used? Also, the INTERNAL_ORDER bit is available. It is used to provide the DONT_REPEAT functionality in normal queues (as well as the time-out feature, but you don't need that). |
|
|
yes. structures get aligned to 4/8 bytes depending on architecture anyway and save file sizes aren't an issue. I wasn't aware of INTERNAL_ORDER though. I'll check it out. edit: if only it was named more inappropriately... Build-once orders are anything but internal. I can resubmit a patch that uses this flag, but will feel guilty ;) |
|
|
I was more concerned with needless bandwidth usage than savefiles. As mentionned, if you don't like INTERNAL_ORDER, the 3 lower bits also seem to be available. |
|
|
ah ok, good point. i'll submit a new one soon. |
|
|
as promised. reverted Command::options type to uchar and sanitized INTERNAL_ORDER (I hope.) |
|
|
committed in r4191. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-07-28 15:07 | imbaczek | New Issue | |
| 2007-07-28 15:07 | imbaczek | File Added: build_once.patch | |
| 2007-07-28 15:43 | trepan | Note Added: 0001033 | |
| 2007-07-29 13:25 | imbaczek | Note Added: 0001034 | |
| 2007-07-29 13:29 | imbaczek | Note Edited: 0001034 | |
| 2007-07-29 16:03 | trepan | Note Added: 0001035 | |
| 2007-07-29 17:25 | imbaczek | Note Added: 0001036 | |
| 2007-07-29 22:09 | imbaczek | File Added: build_once_v2.patch | |
| 2007-07-29 22:15 | imbaczek | Note Added: 0001037 | |
| 2007-08-13 18:22 | imbaczek | Status | new => resolved |
| 2007-08-13 18:22 | imbaczek | Resolution | open => fixed |
| 2007-08-13 18:22 | imbaczek | Assigned To | => imbaczek |
| 2007-08-13 18:22 | imbaczek | Note Added: 0001097 |
