View Issue Details

IDProjectCategoryView StatusLast Update
0000565Spring engineGeneralpublic2007-08-09 00:15
Reporterimbaczek Assigned Toimbaczek  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000565: [patch] cannons shoot closer the higher they get built, not the other way around
Descriptionthe topic says it all. to test, build a guardian on a hill and in the valley of small divide and see which one is able to shoot farther.
Additional Informationalso included is heightMod, which was present in 74b3, but disappeared in revision 3741.
TagsNo tags attached.
Attached Files
fix_cannon_range.patch (Attachment missing)
fix_cannon_range_v2.patch (Attachment missing)
more_fixes_to_weapons.patch (Attachment missing)
more_cannon_range_tweaks.patch (Attachment missing)
Checked infolog.txt for Errors

Relationships

has duplicate 0000563 resolvedimbaczek Weapons cannot have height-based range boost in 75b1 
has duplicate 0000537 resolvedimbaczek Range of projectile weapons not affected by height 

Activities

imbaczek

2007-07-21 01:22

reporter   ~0001026

oops don't commit the cannon.cpp part, it's just logging.

imbaczek

2007-07-21 11:21

reporter   ~0001027

a better version:

- fixed cannons not able to shoot as far from high ground as they should
- fixed infinite lower cylinder when cylindertargetting is active
- reintroduced heightMod to TryTarget
- added heightMod tag (height difference is multiplied by this value before checking range), default 0.8 for Cannon weapon type, 0.2 for everything else (i.e. stays as it was)

imbaczek

2007-07-25 19:16

reporter   ~0001032

some more fixes:
- beamlasers have heightmod=1 by default (used to be 0.2) so they use pure spherical targeting now
- fixes in glBallisticCircle (use heightmod also in drawing range circles.)

Auswaschbar

2007-08-02 14:50

reporter   ~0001039

Commited to trunk.

Big Thanks

imbaczek

2007-08-06 19:23

reporter   ~0001049

more_cannon_range_tweaks.patch:
- added heightBoostFactor - a float tag that gives control of cannon height range boost (more than 1 means increased range, 0 means the cannon has fixed range regardless of height difference to target. default is a magic value calculated on weapon init, based on range tag and theoretical max range.)
- changed Cannon::GetRange2D so it uses something closer to real-world physics.

imbaczek

2007-08-09 00:14

reporter   ~0001055

commited additional tweaks (my first, wee) with some more changes to trunk, r4164.

Issue History

Date Modified Username Field Change
2007-07-21 00:00 imbaczek New Issue
2007-07-21 00:00 imbaczek File Added: fix_cannon_range.patch
2007-07-21 01:22 imbaczek Note Added: 0001026
2007-07-21 11:21 imbaczek File Added: fix_cannon_range_v2.patch
2007-07-21 11:21 imbaczek Note Added: 0001027
2007-07-25 19:14 imbaczek File Added: more_fixes_to_weapons.patch
2007-07-25 19:16 imbaczek Note Added: 0001032
2007-08-02 14:50 Auswaschbar Note Added: 0001039
2007-08-06 19:17 imbaczek File Added: more_cannon_range_tweaks.patch
2007-08-06 19:23 imbaczek Note Added: 0001049
2007-08-09 00:08 imbaczek Status new => assigned
2007-08-09 00:08 imbaczek Assigned To => imbaczek
2007-08-09 00:14 imbaczek Note Added: 0001055
2007-08-09 00:15 imbaczek Status assigned => resolved
2007-08-09 00:15 imbaczek Resolution open => fixed
2007-08-09 00:16 imbaczek Relationship added has duplicate 0000563
2007-08-09 00:17 imbaczek Relationship added has duplicate 0000537