2019-08-26 11:32 CEST

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0005273Spring engineGeneralpublic2017-07-07 21:40
Reporterabma 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
Product Version101.0+git 
Target VersionFixed in Version 
Summary0005273: remove SDL2/1 compatibility keycode handling stuff
Descriptionthis line is hit mostly with special keys:

https://github.com/spring/spring/blob/develop/rts/System/Platform/SDL1_keysym.cpp#L291


i.e. ALTGR, ß, ä, ö, ü, ...
Additional Informationthis translation should be completely removed!


the same for https://github.com/spring/spring/blob/develop/cont/LuaUI/Headers/keysym.h.lua

in short:

number based keycodes need to die! :-)
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0016429

abma (administrator)

should be done past spring 102.0

~0016430

hokomoko (developer)

Though somehow some of these characters did work on 100 when it already used SDL2

~0016440

abma (administrator)

just informal:

common french keyboard layout:

http://www.languagesource.com/acatalog/frenchusb.jpg

for typing "1", SHIFT+& has to be pressed! (WTF?)

~0016441

silentwings (reporter)

I guess its for office workers who would normally use the numpad for numbers.

~0016605

abma (administrator)

sorry, dumb question:

what needs to be done at engine side?

atm i only removed the SDL1_keysym stuff, but not sure if there is needed more work?!

https://github.com/spring/spring/commits/keysym-remove

~0016606

abma (administrator)

i guess a new event needs to be added with
SDL_GetScancodeName(event->key.keysym.scancode)
SDL_GetKeyName(event->key.keysym.sym)

so no more ints are used?!
+Notes

-Issue History
Date Modified Username Field Change
2016-06-10 22:37 abma New Issue
2016-06-10 22:37 abma Note Added: 0016429
2016-06-11 11:55 hokomoko Note Added: 0016430
2016-06-14 01:22 abma Note Added: 0016440
2016-06-14 10:54 silentwings Note Added: 0016441
2016-07-06 20:58 abma Target Version => 103.0
2016-07-19 15:28 abma Target Version 103.0 => 104.0
2016-08-09 22:56 abma Note Added: 0016605
2016-08-09 23:03 abma Note Added: 0016606
2017-07-07 21:40 abma Target Version 104.0 =>
+Issue History