| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 0005273 | Spring engine | General | public | 2016-06-10 22:37 | 2017-07-07 21:40 | ||||||||
| Reporter | abma | ||||||||||||
| Assigned To | |||||||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||||||
| Status | new | Resolution | open | ||||||||||
| Product Version | 101.0+git | ||||||||||||
| Target Version | Fixed in Version | ||||||||||||
| Summary | 0005273: remove SDL2/1 compatibility keycode handling stuff | ||||||||||||
| Description | this line is hit mostly with special keys: https://github.com/spring/spring/blob/develop/rts/System/Platform/SDL1_keysym.cpp#L291 i.e. ALTGR, ß, ä, ö, ü, ... | ||||||||||||
| Additional Information | this translation should be completely removed! the same for https://github.com/spring/spring/blob/develop/cont/LuaUI/Headers/keysym.h.lua in short: number based keycodes need to die! :-) | ||||||||||||
| Tags | No tags attached. | ||||||||||||
| Checked infolog.txt for Errors | |||||||||||||
| Attached Files |
| ||||||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
abma (administrator) 2016-06-10 22:37 |
should be done past spring 102.0 |
|
hokomoko (developer) 2016-06-11 11:55 |
Though somehow some of these characters did work on 100 when it already used SDL2 |
|
abma (administrator) 2016-06-14 01:22 |
just informal: common french keyboard layout: http://www.languagesource.com/acatalog/frenchusb.jpg for typing "1", SHIFT+& has to be pressed! (WTF?) |
|
silentwings (reporter) 2016-06-14 10:54 |
I guess its for office workers who would normally use the numpad for numbers. |
|
abma (administrator) 2016-08-09 22:56 |
sorry, dumb question: what needs to be done at engine side? atm i only removed the SDL1_keysym stuff, but not sure if there is needed more work?! https://github.com/spring/spring/commits/keysym-remove |
|
abma (administrator) 2016-08-09 23:03 |
i guess a new event needs to be added with SDL_GetScancodeName(event->key.keysym.scancode) SDL_GetKeyName(event->key.keysym.sym) so no more ints are used?! |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-06-10 22:37 | abma | New Issue | |
| 2016-06-10 22:37 | abma | Note Added: 0016429 | |
| 2016-06-11 11:55 | hokomoko | Note Added: 0016430 | |
| 2016-06-14 01:22 | abma | Note Added: 0016440 | |
| 2016-06-14 10:54 | silentwings | Note Added: 0016441 | |
| 2016-07-06 20:58 | abma | Target Version | => 103.0 |
| 2016-07-19 15:28 | abma | Target Version | 103.0 => 104.0 |
| 2016-08-09 22:56 | abma | Note Added: 0016605 | |
| 2016-08-09 23:03 | abma | Note Added: 0016606 | |
| 2017-07-07 21:40 | abma | Target Version | 104.0 => |
| Issue History |