0005165: Null pointer dereference in ModelParser

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005165

Spring engine

General

public

2016-03-12 07:45

2016-03-12 10:55

Reporter

hokomoko

Assigned To

Priority

normal

Severity

minor

Reproducibility

sometimes

Status

resolved

Resolution

fixed

Product Version

101.0+git

Target Version

Fixed in Version

Summary

0005165: Null pointer dereference in ModelParser

Description

When ModelParser is safe deleted, if the preload thread is still running it will fail on reaching https://github.com/spring/spring/blob/87e6ba1/rts/Rendering/Models/IModelParser.cpp#L134 since the pointer is nullptr.

My solution for that would've been putting the queue handling in the modelparser itself (as I originally did).

Kloot I have a suspicion that you won't like it as you split it out of the ModelParser in the first place.

Additional Information

http://buildbot.springrts.com/builders/validationtests/builds/5277/steps/validation%20test/logs/stdio

Tags

No tags attached.

Checked infolog.txt for Errors

Attached Files

Relationships

Relationships

Notes

~0016047

Anonymous (viewer)

2016-03-12 10:55

Fix 3a75f32292b097885575bb157d4d1ba65bc9b7ad committed to develop branch: fix 0005165
change modelParser from global pointer to function-static reference
s/modelParser/modelLoader to match the class name, repo: spring changeset id: 6820

Notes

Date Modified	Username	Field	Change
Issue History
2016-03-12 07:45	hokomoko	New Issue
2016-03-12 10:55		Changeset attached	=> spring develop 3a75f322
2016-03-12 10:55	Anonymous	Note Added: 0016047
2016-03-12 10:55	Anonymous	Status	new => resolved
2016-03-12 10:55	Anonymous	Resolution	open => fixed

Issue History