2019-08-26 11:26 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0005084Spring engineLuapublic2016-03-03 16:01
Reportersilentwings 
Assigned ToKloot 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
Product Version100.0+git 
Target VersionFixed in Version 
Summary0005084: luaui can now reload itself, but can't disable itself
DescriptionIt would be useful if (presumably using the same system as allows "luaui reload" to be called from within luaui) the command "luaui disable" could also work.
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0015735

Kloot (developer)

It crossed my mind, but didn't think it would ever be needed. What's the use-case?

~0015736

silentwings (reporter)

Last edited: 2016-02-12 01:09

View 3 revisions

When using chonsole (a chili chat input console, https://github.com/gajop/chonsole which for example BAR now uses) it becomes impossible to disable luaui without first disabling the chat console and falling back on the engines inbuilt one.

To see the benefits of chonsole, fire up bar:test and e.g. type a '/' into the console.

~0015737

Kloot (developer)

ah ok, will go into 101+ then (all 4 lines of code)

~0015740

gajop (developer)

I can make it possible to disable LuaUI through chonsole much like I did it for /luaui reload until https://github.com/gajop/chonsole/commit/f24f8f91b3cf95754ed48b0d9fc5422f22c98403
 , but the reasons to allow it to work LuaUI directly is the same as it was in https://github.com/spring/spring/commit/28782a5d5e64ffbbb2eb1c6f8648f9dbb4af1576#commitcomment-15498634

~0015741

silentwings (reporter)

Don't worry, it can wait for 101+

~0015962

Anonymous (viewer)

Fix c3c4e37fed738f0d26ed7200f1838ffc53e53e1b committed to develop branch: fix 0005084, repo: spring changeset id: 6702
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2016-02-12 00:09 silentwings New Issue
2016-02-12 01:06 Kloot Note Added: 0015735
2016-02-12 01:07 silentwings Note Added: 0015736
2016-02-12 01:08 silentwings Note Edited: 0015736 View Revisions
2016-02-12 01:09 silentwings Note Edited: 0015736 View Revisions
2016-02-12 01:27 Kloot Note Added: 0015737
2016-02-12 12:07 gajop Note Added: 0015740
2016-02-12 12:18 silentwings Note Added: 0015741
2016-02-12 22:17 Kloot Assigned To => Kloot
2016-02-12 22:17 Kloot Status new => assigned
2016-03-03 16:01 Changeset attached => spring develop c3c4e37f
2016-03-03 16:01 Anonymous Note Added: 0015962
2016-03-03 16:01 Anonymous Status assigned => resolved
2016-03-03 16:01 Anonymous Resolution open => fixed
+Issue History