| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0005074 | Spring engine | Lua | public | 2016-02-09 06:39 | 2016-02-09 12:04 | ||||
| Reporter | Google_Frog | ||||||||
| Assigned To | |||||||||
| Priority | normal | Severity | major | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Product Version | 100.0+git | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005074: Spring.IsPosIn{Los, Radar, AirLos} and Spring.GetPositionLosState now require allyTeamID | ||||||||
| Description | These four callouts now crash if called from LuaUI without an allyTeamID argument. In 100.0 the callout used the allyTeamID of the player running the widget. I assume the same held for unsynced luarules. In the dev engine these callouts now cause an error such as this one: [f=0020640] [cawidgets.lua] Error: Error in Update(): [string "LuaUI/Widgets/gui_defenserange.lua"]:755: bad argument 0000004 to 'spGetPositionLosState' (Invalid allyTeam) I think that the 4th argument should go back to being optional. Otherwise a lot of code will need to be updated. | ||||||||
| Tags | No tags attached. | ||||||||
| Checked infolog.txt for lua Errors | |||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Google_Frog (reporter) 2016-02-09 07:02 |
I made a temporary change so I can continue testing other things. https://github.com/ZeroK-RTS/Zero-K/commit/fd09055443c5b2a15bfbd72d3d8f155dc6689aca |
|
Anonymous (viewer) 2016-02-09 12:04 |
Fix 3f33ff37db15c656173dfd6c9c88a3a8d7a27781 committed to develop branch: fix 0005074, repo: spring changeset id: 6584 |
| Notes |
| Related Changesets |
|||
|
spring: develop 3f33ff37
Timestamp: 2016-02-09 12:07:15 Author: rtri [ Details ] [ Diff ] |
fix 0005074 | ||
| mod - rts/Lua/LuaSyncedRead.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-02-09 06:39 | Google_Frog | New Issue | |
| 2016-02-09 07:02 | Google_Frog | Note Added: 0015705 | |
| 2016-02-09 12:04 | Changeset attached | => spring develop 3f33ff37 | |
| 2016-02-09 12:04 | Anonymous | Note Added: 0015706 | |
| 2016-02-09 12:04 | Anonymous | Status | new => resolved |
| 2016-02-09 12:04 | Anonymous | Resolution | open => fixed |
| Issue History |