2019-08-24 09:22 CEST

View Issue Details Jump to Notes ] Related Changesets ]
IDProjectCategoryView StatusLast Update
0005074Spring engineLuapublic2016-02-09 12:04
ReporterGoogle_Frog 
Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
Product Version100.0+git 
Target VersionFixed in Version 
Summary0005074: Spring.IsPosIn{Los, Radar, AirLos} and Spring.GetPositionLosState now require allyTeamID
DescriptionThese four callouts now crash if called from LuaUI without an allyTeamID argument. In 100.0 the callout used the allyTeamID of the player running the widget. I assume the same held for unsynced luarules.

In the dev engine these callouts now cause an error such as this one:
[f=0020640] [cawidgets.lua] Error: Error in Update(): [string "LuaUI/Widgets/gui_defenserange.lua"]:755: bad argument 0000004 to 'spGetPositionLosState' (Invalid allyTeam)

I think that the 4th argument should go back to being optional. Otherwise a lot of code will need to be updated.
TagsNo tags attached.
Checked infolog.txt for lua Errors
Attached Files

-Relationships
+Relationships

-Notes

~0015705

Google_Frog (reporter)

I made a temporary change so I can continue testing other things. https://github.com/ZeroK-RTS/Zero-K/commit/fd09055443c5b2a15bfbd72d3d8f155dc6689aca

~0015706

Anonymous (viewer)

Fix 3f33ff37db15c656173dfd6c9c88a3a8d7a27781 committed to develop branch: fix 0005074, repo: spring changeset id: 6584
+Notes

+Related Changesets

-Issue History
Date Modified Username Field Change
2016-02-09 06:39 Google_Frog New Issue
2016-02-09 07:02 Google_Frog Note Added: 0015705
2016-02-09 12:04 Changeset attached => spring develop 3f33ff37
2016-02-09 12:04 Anonymous Note Added: 0015706
2016-02-09 12:04 Anonymous Status new => resolved
2016-02-09 12:04 Anonymous Resolution open => fixed
+Issue History